Added "Shinychu" card for testing wrong shiny evaluation #504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[no important files changed]
Hey!
This pull request adds a (useless) not covered case in Gotta Snatch 'Em All` exercise, which is the "fake shiny" card (feel free to name the case the way you like).
Basically the instructions of the last part of the exercise states:
That means that cards starting with "Shiny" without a space should not be considered shiny cards. For example, the totally made up card Shinychu should not be considered as shiny. However in the current state of the exercise I could write a function that filters for strings starting with "Shiny" and the tests pass.
To correct this behavior, I added the Shinychu card to all the tests regarding shiny cards. For example:
This is probably a useless correction, but I think it better completes the exercise.
PS: this is a retake of a previous pull request, but with the [no important files changed] string added to the commit body since there is no need at all to re-test all students' submissions.