Sync problem specs #273
Sync problem specs #273
Conversation
BNAndras
added
x:action/sync
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
BNAndras
force-pushed
the
sync-problem-specs
branch
from
4e0eab7 to
4624d7e
Compare
exercises/practice/bob/bob_test.f90
Outdated
| ! Test 21: multiple line question | ||
| call assert_equal("Whatever.", hey(""// & | ||
| & "Does this cryogenic chamber make me look fat?"// & | ||
| & "No."), "multiple line question") | ||
| & "Does this cryogenic chamber make me look fat?"), "multiple line question") |
There was a problem hiding this comment.
Isn't there supposed to be a newline in here?
There was a problem hiding this comment.
The change is dropping the No part so it’s a single sentence with a newline at the beginning. So that newline should still be there at the beginning.
There was a problem hiding this comment.
"input": {
"heyBob": "\nDoes this cryogenic chamber make\n me look fat?"
},
The spec has two newlines.
There was a problem hiding this comment.
I updated the test suite with named constants to better represent the alternate whitespace characters. Enabling test 24 required the example solution be updated since trim_len() only accounts for trailing blank spaces. The Linux CI is passing once I fixed the expected value for test 21, but the macOS 12 one is having some trouble finding the GFortran compiler.
BNAndras
force-pushed
the
sync-problem-specs
branch
from
41f6be9 to
9fef4a0
Compare
No description provided.