New practice exercise: complex-numbers
#482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiegillet
added
x:module/practice-exercise
ceddlyburge
approved these changes
May 15, 2022
| ] | ||
|
|
||
|
|
||
| tests : Test |
There was a problem hiding this comment.
Does this work with the test runner? I think it does but can't remember all the details, we should probably add some documentation somewhere!
And does it format the test results in a nice way on the website? I also can't remember where we are at with grouping tests in headings to make this better.
There was a problem hiding this comment.
Yes, it works fine.
Grouping the tests with the headings is only for concept exercises, this one is a practice exercise, so there is nothing special in the UI. It's also OK to have helper functions like above because the test file is fully visible in the UI.
|
Thank you for the review, don't worry about the timing, I certainly don't :) |
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #480.