Skip to content

Add list concept and associated exercise #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
May 28, 2021
Merged

Add list concept and associated exercise #365

merged 25 commits into from
May 28, 2021

Conversation

ceddlyburge
Copy link
Contributor

No description provided.

@ceddlyburge ceddlyburge changed the title WIP: Add list concept and associated exercise Add list concept and associated exercise May 14, 2021
@ceddlyburge ceddlyburge requested a review from mpizenberg May 14, 2021 20:21
ceddlyburge and others added 25 commits May 28, 2021 16:37
@ceddlyburge @mpizenberg
Add config for list concept
1e465c3
@ceddlyburge @mpizenberg
Add about.md for list concept
1a2774d
@ceddlyburge @mpizenberg
Add introduction.md for list concept
7eef816
@ceddlyburge @mpizenberg
Add links.json for list concept
782c26a
@ceddlyburge @mpizenberg
Fix formatting / typos
78871c3
@ceddlyburge @mpizenberg
Add hints for list concept exercise
f63f5a7
@ceddlyburge @mpizenberg
Add instructions for list concept exercise
8316179
@ceddlyburge @mpizenberg
Add introduction for elm concept exercise
abb1653
@ceddlyburge @mpizenberg
Add design for list concept exercise
6028283
@ceddlyburge @mpizenberg
Add exemplar solution for list concept exercise
ccf7f3e
@ceddlyburge @mpizenberg
Add initial elm template for list concept exercise
a7151d4
@ceddlyburge @mpizenberg
Add tests for list concept exercise
73f6b06
@ceddlyburge @mpizenberg
Add config for list concept exercise
5977207
@ceddlyburge @mpizenberg
Fix up code after running examplar through tests, and run elm-format
6fbcd7c
@mpizenberg
docs (exercis instructions): use 1 sentence per line
e948d2b
@mpizenberg
docs (exercise instructions): small rephrasing
f36eb82
@mpizenberg
docs (design): typo
dae84bf
@mpizenberg
docs (exercise instructions): use --> for result comments
c0069cd
@mpizenberg
Review exercise introduction
0846103
@mpizenberg
Fix type in tests
3b4547b
@mpizenberg
Simplify concept intro
653dbf7
@mpizenberg
Fix json indentation
b2564d4
@mpizenberg
Update links descriptions
74334df
@mpizenberg
Review concept about.md
6900ad0
@mpizenberg
Add lists concept and exercise to config.json
42708b7
mpizenberg
mpizenberg approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@mpizenberg mpizenberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed a few little things here and there, but everything looks really good to me! thanks for this!

If you're ok with the changes I made, don't hesitate to squash merge this.

@ceddlyburge ceddlyburge merged commit a03666a into main May 28, 2021
@ceddlyburge ceddlyburge deleted the list branch May 28, 2021 17:19
This was referenced Jul 14, 2022
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpizenberg mpizenberg mpizenberg approved these changes

Assignees
No one assigned
Labels
x:size/large Large amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ceddlyburge @mpizenberg @ErikSchierboom