-
-
Notifications
You must be signed in to change notification settings - Fork 402
Updates to test execution documentation #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The additions are great! Good job. It reads very well, the wording fits the style of other documents.
Here are some potential improvements that we could make:
I would just want a small change to the information order. In case somebody is impatient, I want them to see at the very top: here's how you run all tests (mix test
) and here's how you unskip tests, which are the two basic things you need to know to solve the exercise. Everything else that's "nice to know" but not essential should come afterwards.
This would roughly mean that I would like the beginning of the document to stay as it was, and then after the ## Pending tests
section we can start explaining how a test block looks like, which testing framework we're using and what other extra options are there.
As a rule, we try to write all code snippets in a way that they are actual correct code snippets without syntax errors. They don't have to compile, they just need to be semantically correct so the the syntax highlighting will manage to color them correctly. So, to mark a line that doesn't do anything, we would write # ...
instead of ...
(*), or to mark a string whose content doesn't matter, we would write "..."
instead of ...
.
Another general thing that could be improved is how links are written. We should make use of markdown's link syntax and provide nice link text instead of relying on the platform turning raw URLs into links, so for example, instead of:
Elixir's test execution tool: https://hexdocs.pm/mix/Mix.Tasks.Test.html
Write:
[Elixir's test execution tool](https://hexdocs.pm/mix/Mix.Tasks.Test.html)
(*) PS:...
is technically a valid expression in Elixir because three dots are allowed as a variable name, but a lot of highlighting tools don't know that 😁
make valid elixir code. Co-authored-by: Angelika Tyborska <angelikatyborska@fastmail.com>
all suggestions/recommendations made! thx!! |
I'm assuming this is ready for review even though the PR is a draft because I can't see anything missing and I will make it not-a-draft :) |
I reviewed how the file I took all your additions and put them in |
Thank you a lot for your contribution 💜 I'll merge it now. I had to do some other minor changes, I decided to do them myself not to bother you anymore. If I made a mistake there, let me know. |
of course and i hope i was not more effort than value! 😉 and thank you! |
Hi!
Here is my documentation style. Looking forward to many critiques so I can improve! 😄
Closes #906