-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scripts based on recent configlet changes #296
Comments
* Don't run configlet lint manually in check_formatting.dart * 🐛 (exercises/concepts) Add stub content to dart files This is to allow dart formatting checks to pass in CI * 🚧 (presubmit) Temporarily disable `configlet fmt` Please see #296
@devkabiir I'm going to start looking into this ticket. |
@devkabiir It does seem like #301 resolves this issue. Is there something else related to this? |
I think the presubmit script hasn't been updated. |
@devkabiir Okay, I'll address that in my branch. Thanks But it looks like configlet still doesn't have a format option, so that part will likely have to wait |
That is correct. We don't yet have that, but we will at some point :) |
@ErikSchierboom Has configlet been updated to format the config files? |
@Stargator configlet formats exercise config files, but does not yet format the track-level config file. |
@devkabiir Updated the original post to track the other scripts that need to be updated. |
I noticed in the recent PR #295, that our
check_formatting
is runningconfiglet lint
manually, which is no longer required since #283 added a separate workflow for it.The following scripts need to be updated:
check_formatting
create_exercise
presubmit
also needs an update.The text was updated successfully, but these errors were encountered: