Skip to content

Commit 02b330f

Browse files
authored
Don't run configlet lint manually in check_formatting.dart (#301)
* Don't run configlet lint manually in check_formatting.dart * πŸ› (exercises/concepts) Add stub content to dart files This is to allow dart formatting checks to pass in CI * 🚧 (presubmit) Temporarily disable `configlet fmt` Please see #296
1 parent c871761 commit 02b330f

File tree

5 files changed

+5
-12
lines changed

5 files changed

+5
-12
lines changed

β€Žbin/check_formatting.dart

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,6 @@ Future main() async {
55
final CommonUtils utils = CommonUtils();
66
int errorCode = 0;
77

8-
if (await utils.fetchConfiglet() == 0) {
9-
print('Checking config.json formatting...');
10-
errorCode = await utils.runCmdIfExecutable('bin/configlet', ['lint', '--track-id', 'dart', '.']);
11-
12-
if (errorCode != 0) {
13-
print('Checking config.json formatting failed!!');
14-
await utils.terminate();
15-
throw StateError('Formatting failed.');
16-
}
17-
}
18-
198
print('Checking all Dart files formatting...');
209
errorCode = await utils
2110
.runCmd('pub', ['run', 'dart_style:format', '-i', '0', '-l', '120', '-n', '--set-exit-if-changed', '.']);

β€Žbin/presubmit.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ Future<Null> main() async {
66

77
if (await utils.fetchConfiglet() == 0) {
88
print('Formatting config.json...');
9-
await utils.runCmdIfExecutable('bin/configlet', ['fmt', '.']);
9+
print('Unsupported operation: Please see https://github.com/exercism/dart/issues/296');
10+
// await utils.runCmdIfExecutable('bin/configlet', ['fmt', '.']);
1011
}
1112

1213
print('Formatting all Dart files...');
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
// TODO
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
// TODO
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
// TODO

0 commit comments

Comments
Β (0)