Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slug and tags to config.json #142

Merged
merged 1 commit into from
Jun 12, 2021
Merged

Add slug and tags to config.json #142

merged 1 commit into from
Jun 12, 2021

Conversation

0x647262
Copy link
Contributor

@0x647262 0x647262 commented Jun 10, 2021

Closes #137
Closes #118
Closes #117

Filled the tags out to the best of my ability. If I'm missing anything, let me know and I'll get it added!

@0x647262 0x647262 changed the title Chore: Add slug and tags to config.json Add slug and tags to config.json Jun 10, 2021
config.json Outdated
@@ -1,5 +1,6 @@
{
"language": "D",
"blurb": "D is a general-purpose programming language with static typing, systems-level access, and C-like syntax. With the D Programming Language, write fast, read fast, and run fast.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the language's official introduction text verbatim, right? We usually don't want to copy things literally due to licensing issues. In https://github.com/exercism/d/pull/144/files, I took a stab at writing a blurb. How does that look like? Maybe you can use that and tweak it a bit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted to leave your blurb as-is. I think it fits the language just fine!

@ErikSchierboom
Copy link
Member

Thanks for working on this BTW!

@0x647262
Copy link
Contributor Author

@ErikSchierboom I'd like to tackle #117 with this merge as well, if possible.

I took a look at the key features documentation on: https://github.com/exercism/docs/blob/main/building/tracks/config-json.md#key-features, but it seems there are no predefined features there. Would grabbing shared key features from other tracks config.json files be fine in this case?

@ErikSchierboom
Copy link
Member

ErikSchierboom commented Jun 11, 2021

I'd like to tackle #117 with this merge as well, if possible.

We usually prefer to merge things sooner than later, but I can keep this open if you'd like :)

[...] it seems there are no predefined features there.

That's correct. This is due to the key features being track-specific highlights.

Would grabbing shared key features from other tracks config.json files be fine in this case?

The idea is that these key features showcase why a student would want to join that track. So usually you'd come up with the six things that showcase the track best, and then write the text for them. There is likely some overlap, so you could definitely take inspiration from other tracks, although it is likely that the text needs to be modified.

@0x647262
Copy link
Contributor Author

@ErikSchierboom all set!

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@ErikSchierboom ErikSchierboom merged commit 2c6e085 into exercism:main Jun 12, 2021
@ErikSchierboom
Copy link
Member

@0x647262 You can see the key features on https://exercism.lol/tracks/d (provided you've not joined the track)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add language blurb [v3] Add tags [v3] Add key features
2 participants