-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slug and tags to config.json #142
Conversation
config.json
Outdated
@@ -1,5 +1,6 @@ | |||
{ | |||
"language": "D", | |||
"blurb": "D is a general-purpose programming language with static typing, systems-level access, and C-like syntax. With the D Programming Language, write fast, read fast, and run fast.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the language's official introduction text verbatim, right? We usually don't want to copy things literally due to licensing issues. In https://github.com/exercism/d/pull/144/files, I took a stab at writing a blurb. How does that look like? Maybe you can use that and tweak it a bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opted to leave your blurb as-is. I think it fits the language just fine!
Thanks for working on this BTW! |
@ErikSchierboom I'd like to tackle #117 with this merge as well, if possible. I took a look at the key features documentation on: https://github.com/exercism/docs/blob/main/building/tracks/config-json.md#key-features, but it seems there are no predefined features there. Would grabbing shared key features from other tracks |
We usually prefer to merge things sooner than later, but I can keep this open if you'd like :)
That's correct. This is due to the key features being track-specific highlights.
The idea is that these key features showcase why a student would want to join that track. So usually you'd come up with the six things that showcase the track best, and then write the text for them. There is likely some overlap, so you could definitely take inspiration from other tracks, although it is likely that the text needs to be modified. |
@ErikSchierboom all set! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
@0x647262 You can see the key features on https://exercism.lol/tracks/d (provided you've not joined the track) |
Closes #137Closes #118
Closes #117
Filled the tags out to the best of my ability. If I'm missing anything, let me know and I'll get it added!