Skip to content

Sync linked-list docs with problem-specifications #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

kytrinyx
Copy link
Member

@kytrinyx kytrinyx commented Apr 9, 2023

The linked-list exercise has been overhauled as part of a project to make practice exercises more consistent and friendly.

For more context, please see the discussion in the forum, as well as the pull request that updated the exercise in the problem-specifications repository:


If you approve this pull request, I will eventually merge it. However, if you are happy with this change please merge the pull request, as it will get the changes into the hands of the students much more quickly.

If this pull request contradicts the exercise on your track, please add a review with request changes. This will block the pull request from getting merged.

Otherwise, as discussed in the forum post linked to above, we aim to take an optimistic merging approach.

If you wish to suggest tweaks to these changes, please open a pull request to the exercism/problem-specifications repository to discuss, so that everyone who has an interest in the shared exercise descriptions can participate.

The linked-list exercise has been overhauled as part of a project
to make practice exercises more consistent and friendly.

For more context, please see the discussion in the forum, as well as
the pull request that updated the exercise in the problem-specifications
repository:

- https://forum.exercism.org/t/new-project-making-practice-exercises-more-consistent-and-human-across-exercism/3943
- exercism/problem-specifications#2245
@ErikSchierboom ErikSchierboom merged commit 4bb8545 into main Apr 11, 2023
@ErikSchierboom ErikSchierboom deleted the sync-linked-list-docs branch April 11, 2023 07:13
@michalporeba
Copy link
Contributor

@ErikSchierboom there are a few things to consider here, or in a separate issue not to block this PR.
The change removes the stipulation that the input will not be incorrect. It also removes the mentions of specific typical operations: pop, push, shift, unshift. At the moment the scaffold and the tests cover only those four and do not support removal from the middle. I think the code will have to change, but how much is something to consider and decide on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants