Skip to content

feat: add pig-latin practice exercise #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ahans
Copy link
Contributor

@ahans ahans commented Feb 20, 2024

I'm not entirely happy with the example implementation yet.

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Feb 20, 2024
@ahans ahans mentioned this pull request Feb 20, 2024
11 tasks
@@ -0,0 +1,68 @@
#include "pig_latin.h"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file and the .h obviously need to go to .meta/example.{h,cpp}.

@vaeng
Copy link
Contributor

vaeng commented Feb 20, 2024

Oh, no. I did not read that! Sorry. I also made a PR for that: #812

@ahans
Copy link
Contributor Author

ahans commented Feb 20, 2024

Oh, no. I did not read that! Sorry. I also made a PR for that: #812

Well, my bad for not mentioning that properly. Your call which one to keep. I think my implementation is more generic. I would have few comments how to make yours slightly more efficient as well.

@vaeng
Copy link
Contributor

vaeng commented Feb 20, 2024

Oh, no. I did not read that! Sorry. I also made a PR for that: #812

Well, my bad for not mentioning that properly. Your call which one to keep. I think my implementation is more generic. I would have few comments how to make yours slightly more efficient as well.

I'd be happy to see your suggestions. Let's make it a double :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants