lint: check files key in track-level config

[bobtfish]

Addresses some of #249

Implements the following rules:

• The "files" key is optional
• The "files" value must be an object
• The "files.solution" key is optional
• The "files.solution" value must be an array
• The "files.solution" values must be valid patterns⁴
• The "files.solution" values must not have duplicates
• The "files.test" key is optional
• The "files.test" value must be an array
• The "files.test" values must be valid patterns⁴
• The "files.test" values must not have duplicates
• The "files.example" key is optional
• The "files.example" value must be an array
• The "files.example" values must be valid patterns⁴
• The "files.example" values must not have duplicates
• The "files.exemplar" key is optional
• The "files.exemplar" value must be an array
• The "files.exemplar" values must be valid patterns⁴
• The "files.exemplar" values must not have duplicates
• The "files.editor" key is optional
• The "files.editor" value must be an array
• The "files.editor" values must be valid patterns⁴
• The "files.editor" values must not have duplicates
• Patterns can only be listed in either the "files.solution", "files.test", "files.example, "files.exemplar or "files.editor array (no overlap)

[ErikSchierboom]

Great! I'll leave the Nim code review to @ee7 .

[ErikSchierboom]

@bobtfish Great!

[ee7]

Again, thanks for working on this. I've done a first pass review - looking good.

I again took the liberty of just pushing the commits - please yell at me if you hate anything, or have any questions. Most notably, a string that ended in % would previously raise an IndexDefect.

There's a few more things I want to have before merging (in particular: a few more test cases, and a warning for bad placeholder usage would indeed be nice) but I think it's pretty close.

[bobtfish]

hey @ee7 thanks for brushing up my code.

Are you going to take this over the line, or would you like me to add the warning? (I think you added the extra tests already, right?)

[ee7]

thanks for brushing up my code.

No problem.

Are you going to take this over the line

@bobtfish Yes - thanks. I'll just add a very basic warning and then I'll merge.

I've also like to add more rules about file patterns to the spec, but we should handle that later.

[ee7]

At the time of writing, this PR produces the following diff to the output of configlet lint, per-track:

ballerina

+A `files.exemplar` value is `.meta/reference/%{snake_slug}.bal`, which is not a unique `files` entry:
+./config.json
+

d

+A `files.test` value is `source/%{snake_slug}.d`, which is not a unique `files` entry:
+./config.json
+
+Configlet detected at least one problem.
+For more information on resolving the problems, please see the documentation:
+https://github.com/exercism/docs/blob/main/building/configlet/lint.md

fortran

+A `files.exemplar` value is `%{snake_slug}.f90`, which is not a unique `files` entry:
+./config.json
+
+Configlet detected at least one problem.
+For more information on resolving the problems, please see the documentation:
+https://github.com/exercism/docs/blob/main/building/configlet/lint.md

groovy

+A `files.exemplar` value is `.meta/src/reference/groovy/%{pascal_slug}.groovy`, which is not a unique `files` entry:
+./config.json
+
+Configlet detected at least one problem.
+For more information on resolving the problems, please see the documentation:
+https://github.com/exercism/docs/blob/main/building/configlet/lint.md

java

+A `files.exemplar` value is `.meta/src/reference/java/%{pascal_slug}.java`, which is not a unique `files` entry:
+./config.json
+
+Configlet detected at least one problem.
+For more information on resolving the problems, please see the documentation:
+https://github.com/exercism/docs/blob/main/building/configlet/lint.md

pharo-smalltalk

+A `files.exemplar` value is `.meta/solution/%{pascal_slug}.class.st`, which is not a unique `files` entry:
+./config.json
+
+Configlet detected at least one problem.
+For more information on resolving the problems, please see the documentation:
+https://github.com/exercism/docs/blob/main/building/configlet/lint.md

plsql

+A `files.test` value is `ut_%{snake_slug}#.plsql`, which is not a unique `files` entry:
+./config.json
+
+Configlet detected at least one problem.
+For more information on resolving the problems, please see the documentation:
+https://github.com/exercism/docs/blob/main/building/configlet/lint.md

vimscript

+A `files.exemplar` value is `example.vim`, which is not a unique `files` entry:
+./config.json
+
+Configlet detected at least one problem.
+For more information on resolving the problems, please see the documentation:
+https://github.com/exercism/docs/blob/main/building/configlet/lint.md