Skip to content

Conversation

@lukasbindreiter
Copy link
Contributor

As far as I can tell no click features are used that prevent an upgrade to v8 of click.

See jupyter-book/jupyter-book#1590 for more info as to why this is necessary.

@welcome
Copy link

welcome bot commented Feb 1, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #69 (24197bd) into main (3bb41e6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files           6        6           
  Lines         660      660           
=======================================
  Hits          599      599           
  Misses         61       61           
Flag Coverage Δ
pytests 90.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb41e6...24197bd. Read the comment docs.

Co-authored-by: Chris Sewell <chrisj_sewell@hotmail.com>
@chrisjsewell chrisjsewell changed the title Remove unnecessary version constraint for click ⬆️ UPGRADE: allow click v8 Feb 1, 2022
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@chrisjsewell chrisjsewell merged commit 5d4de43 into executablebooks:main Feb 10, 2022
@welcome
Copy link

welcome bot commented Feb 10, 2022

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants