-
Notifications
You must be signed in to change notification settings - Fork 18
🔧 MAINTAIN: Updated parser docstrings #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
|
always welcome 😄 |
chrisjsewell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeh just I think the types should not be duplicated in the docstring (plus they can be properly tested by mypy with the type annotations)
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 90.75% 90.75%
=======================================
Files 6 6
Lines 660 660
=======================================
Hits 599 599
Misses 61 61
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
chrisjsewell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!

I was trying to get a little familiar with the code and thought I would use the opportunity to propose completed docstrings for the
parsermodule. If this sort of contribution is welcome, I could try and do the same for the other modules.