Skip to content

refactor: Remove unused constants#205

Open
ftnext wants to merge 1 commit intoexecutablebooks:mainfrom
ftnext:octicon-role-unused-constants
Open

refactor: Remove unused constants#205
ftnext wants to merge 1 commit intoexecutablebooks:mainfrom
ftnext:octicon-role-unused-constants

Conversation

@ftnext
Copy link

@ftnext ftnext commented Jul 1, 2024

Thank you for this awesome library.
I referred to the implementation of the octicon role in icons.py (a3bdfa3).

In reading the implementation, I noticed some unused code, so I propose to remove it.

$ git grep OCTICON_CSS
sphinx_design/icons.py:OCTICON_CSS = """\
$ git grep OCTICON_VERSION
sphinx_design/icons.py:OCTICON_VERSION = "v19.8.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant