Initial Feedback

[chrisjsewell]

Now that most of the documentation and tests are in-place time for some feedback

Main questions before moving to a 0.1 release is probably confirming role/directive names, and maybe css prefix (sd-)

This is intended to replace sphinx-panels; see the README for a section on differences. The main difference are no direct dependence on bootstrap and less direct use of css classes for users.

[chrisjsewell]

cc @choldgraf @jorisvandenbossche @Daltz333 @pradyunsg (how best to get colours working out the box for furo)

[choldgraf]

👍 will give it a look this week

[Daltz333]

Looks good and I'm excited. Couple of thoughts.

• Documentation on applying custom CSS to panels or tabs
• Make sure to clarify that this isn't backwards compatible with sphinx-tabs or sphinx-panels (users might be modifying styles of things)

One thing that I've had a bit more of a pain point (but I'm glad I can do it!) with sphinx-panels was when I needed to apply custom styles in some situations. IE: Having two buttons in a footer was a pain to figure out, and I used a hacky solution. See https://github.com/wpilibsuite/frc-docs/blob/main/source/index.rst

[pradyunsg]

how best to get colours working out the box for furo

I'm happy to add a bunch of CSS for this in Furo directly.

[chrisjsewell]

Documentation on applying custom CSS to panels or tabs

So yeh I planned to document some of the available CSS classes.
But certainly I want to rely less heavily on these here, in preference to having specific directive options for things like margins, padding, colors, etc

Having two buttons in a footer was a pain to figure out

Yeh so now you could do this using grid + grid-item, as opposed to directly via div + classes.

I'm happy to add a bunch of CSS for this in Furo directly.

Cool cheers!

[chrisjsewell]

cc also @mbercx for the aiida stuff 😉

[pradyunsg]

Oh, one bit of feedback I have -- let's tone down the shadows? They're a little too... visible.

Here's an attempt from me, based off of https://tailwindcss.com/docs/box-shadow shadow:

box-shadow: rgba(0, 0, 0, 0) 0px 0px 0px 0px, rgba(0, 0, 0, 0) 0px 0px 0px 0px, rgba(0, 0, 0, 0.1) 0px 1px 3px 0px, rgba(0, 0, 0, 0.06) 0px 1px 2px 0px;

[chrisjsewell]

Oh, one bit of feedback I have -- let's tone down the shadows? They're a little too... visible.

I have changed the default card shadow (which also can be set with the shadow option) from sd-shadow-md to sd-shadow-sm, see
https://sphinx-design.readthedocs.io/en/latest/css_classes.html#shadows

but obviously feel free to make a PR if you think they can be further improved