Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: sphinx >=4,<6 #644

Merged
merged 3 commits into from
Nov 15, 2022
Merged

ENH: sphinx >=4,<6 #644

merged 3 commits into from
Nov 15, 2022

Conversation

AakashGfude
Copy link
Member

No description provided.

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I did a quick look at the docs and they seemed to look fine to me.

I noticed that the code cells in the right margin have an extra padding added to the left, but that may not be related to this change

image

Can you give a quick run-through of the example docs before merging just to make sure?

@AakashGfude
Copy link
Member Author

AakashGfude commented Nov 15, 2022

I noticed that the code cells in the right margin have an extra padding added to the left, but that may not be related to this change

@choldgraf looks like the style is getting inherited from pydata sphinx theme, which we did not overwrite:

aside.sidebar>*

so not related to this PR. But the rest look okay to me.

@mmcky
Copy link
Member

mmcky commented Nov 15, 2022

Coordinating with executablebooks/sphinx-thebe#57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants