Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last-child zero-margin on <dd>'s #586

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

benjaoming
Copy link
Contributor

Hi there 👋

The style for dl's seems to originate from #191 and following some refactors, I don't see any changes or reasons why this margin seems so off.

I suppose it's unintentional that a definition is closer to the succeeding term than the term its actually a definition for?

Before:

image

After:

image

@welcome
Copy link

welcome bot commented Jul 13, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@choldgraf
Copy link
Member

This looks great to me - better UI and 6 removed lines! Thanks for the improvement

@choldgraf choldgraf merged commit d213985 into executablebooks:master Jul 13, 2022
@welcome
Copy link

welcome bot commented Jul 13, 2022

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@benjaoming benjaoming deleted the remove-odd-zero-margin branch July 13, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants