✨ NEW: Add a shadow to topbar, on scroll

[pradyunsg]

Fixes #153

[choldgraf]

Nice! I think this is a nice step. Do you think there is a way that we could make the shadow a bit softer? It seems like it "jumps out" at me on the page, though that might just be because I am used to no shadow and I would get used to it quickly. What do you think?

[pradyunsg]

Done!

Before:

After:

[choldgraf]

This is better! I am happy with this level of boldness :-)

One other quick thought, and maybe this is just me being OCD, but it's kinda bugging me that there is just a tiny bit of space on the left where the shadow doesn't extend, but before we hit the sidebar:

Is that something easily fixable? I don't think it's a dealbreaker

[pradyunsg]

Is that something easily fixable? I don't think it's a dealbreaker

It's tricky with the way that the elements are organised. Maybe someone smart can figure it out, but for now I've set the box-shadow to never overflow over the left/right by setting the box's size to be -6px -- that's what's causing this behavior that you're seeing.

I can tell you it bothers me as much as it bothers you, but "perfect is the enemy of good" -- IOW, I didn't want to spend an hour fighting with the browser. :)

[choldgraf]

Agree 💯, was just mentioning it in case it was an easy fix. I'm +1 on this once the merge conflict is resolved.

[pradyunsg]

If someone else could do the rebase/merge, that'd be great! :)

I don't think I'll be able to get to this at least for a few days.

[choldgraf]

this looks great @pradyunsg - thanks for adding this, I quite like it! 🎉

[pradyunsg]

Yay! I’m glad!