Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintain: upgrade deprecated Node 12 GitHub actions to Node 16 actions (companion to PR #53) #54

Conversation

goxberry
Copy link
Contributor

Some of the GitHub Actions used in the project CI workflow use Node 12 and are deprecated, as dicsussed in PR #53, which adds a Dependabot configuration to automatically scan the project CI configuration and submit pull requests that upgrade the GitHub Actions used by the project.

This pull request is a companion pull request to PR #53 that upgrades the GitHub Actions used in project CI to Node 16 actions, and will avoid having to wait for Dependabot to submit PRs that will make similar changes.

The `actions/checkout@v2` GitHub action uses Node 12, which is
deprecated and scheduled for end-of-life in Summer 2023; see
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
for details.

This commit updates the CI workflows to use `actions/checkout@v3`
instead, which upgrades that action to use Node 16.

Signed-off-by: Geoffrey M Oxberry <goxberry@gmail.com>
The `actions/setup-python@v1` action is another deprecated Node 12
action slated for removal by Summer 2023. This commit updates that
action to `actions/setup-python@v4` to resolve the deprecation
warnings seen in CI output.

Signed-off-by: Geoffrey M Oxberry <goxberry@gmail.com>
The `pre-commit/action@v2.0.0` action is the last of the remaining
Node 12 actions used by the project's CI wokflow. This commit upgrades
that action to `pre-commit/action@v3.0.0`, which uses Node 16 and is
not subject to deprecation.

Signed-off-by: Geoffrey M Oxberry <goxberry@gmail.com>
@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Base: 84.48% // Head: 84.48% // No change to project coverage 👍

Coverage data is based on head (4c79081) compared to base (6cbc68a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   84.48%   84.48%           
=======================================
  Files          10       10           
  Lines        1637     1637           
=======================================
  Hits         1383     1383           
  Misses        254      254           
Flag Coverage Δ
pytests 84.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@goxberry
Copy link
Contributor Author

Closing because this PR has been obsolesced by #56, #57, #58, and #59.

@goxberry goxberry closed this Jan 17, 2023
@goxberry goxberry deleted the goxberry/update-deprecated-node12-actions branch January 17, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants