🐛 FIX: parse_directive_text when body followed by options#520
Closed
chrisjsewell wants to merge 1 commit intomasterfrom
Closed
🐛 FIX: parse_directive_text when body followed by options#520chrisjsewell wants to merge 1 commit intomasterfrom
parse_directive_text when body followed by options#520chrisjsewell wants to merge 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
=======================================
Coverage 90.06% 90.06%
=======================================
Files 16 16
Lines 2103 2103
=======================================
Hits 1894 1894
Misses 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
So cool to see the JS implementation pushing on the python side. Love it. Thanks for making these changes here! |
Member
Author
|
superseded by #580 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was uncovered in executablebooks/markdown-it-docutils#28
The change does not break any existing tests, but I should add a test that would break without this change