Repository navigation
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68278822f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 716f6d7911
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d3d23d0 to
ec96f56
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
# Conflicts: # src/Exceptionless.Web/ClientApp/src/lib/features/auth/index.svelte.ts
fc0f025 to
a4c506a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4c506a146
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bfaa57a3cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3fdd94da54
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
This branch has not been deployed
1 participant
Replace Windows Live authentication with Microsoft Identity Platform v2 and Graph in the API and Svelte UI. Microsoft linking now requires signing in to an existing, email-verified account; unlinked identities cannot sign up, match accounts by email, or bypass this restriction through invitations. Existing linked identities can sign in without changing email-verification state. Editable Microsoft profile email also no longer automatically verifies an email-address change. Integrates latest main and its Svelte root-route cutover.
Validation: Release build passes with zero warnings/errors; six isolated auth-handler tests, eight Microsoft frontend tests, Svelte validation, production build, and rendered signup checks pass. Fresh Astra medium review found no remaining actionable issues after both security fixes.
Pending verification: Current-head hosted Build is pending. New endpoint regressions compile but have not run locally; real Entra consent/Graph callback remains unverified without an app registration.
Approved breaking changes:
/api/v2/auth/liveis replaced by/api/v2/auth/microsoft; the bundled Windows Live client ID and Microsoft signup option are removed. Users must create and verify an account or sign in through another method/password recovery, then link Microsoft in account settings. Microsoft login stays hidden until configured.Verification and implementation details
dotnet build tests/Exceptionless.Tests/Exceptionless.Tests.csproj --configuration Release --no-restore -m:1 /nr:false; direct execution of the Release test DLL with--filter-class Exceptionless.Tests.Api.Handlers.AuthHandlerTests; focused Microsoft Vitest coverage; Svelte validation and production build.User.Read, and a client secret. SetMicrosoftId=<client-id>;MicrosoftSecret=<secret>;inEX_ConnectionStrings__OAuth.