Feature: Populate module info with installed node modules #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome job |
Conflicts: dist/exceptionless.node.js.map
…ss.JavaScript into feature/additionalInfo
|
Is this ready to be tested and merged? |
|
Absolutley. Currently working on #8 for it to make it into the same release. |
|
Awesome! |
Conflicts: dist/exceptionless.node.js.map
|
This now contains support for additional properties (#8), including some unit tests to check for compatibility with common browser properties. |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature (Issue #6) adds a
NodeModuleCollector.tsthat tries to find all currently loaded npm modules:npm ls --depth=0 --jsonto get all installed packages on root level. Those modules are cached, as they won't change during runtime.require.cacheto get all currently cached modules. Those are all JavaScript files that have been required since startup of the application./node_modules/, which is the module name, and makes them unique.