Skip to content

Commit

Permalink
Cleanup: Remove unneeded namespaces.
Browse files Browse the repository at this point in the history
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8334007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106129 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
thestig@chromium.org committed Oct 18, 2011
1 parent c54c43e commit d91db11
Show file tree
Hide file tree
Showing 12 changed files with 95 additions and 105 deletions.
29 changes: 14 additions & 15 deletions printing/emf_win_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ TEST(EmfTest, DC) {
uint32 size;
std::vector<BYTE> data;
{
printing::Emf emf;
Emf emf;
EXPECT_TRUE(emf.Init());
EXPECT_TRUE(emf.context() != NULL);
// An empty EMF is invalid, so we put at least a rectangle in it.
Expand All @@ -63,7 +63,7 @@ TEST(EmfTest, DC) {
}

// Playback the data.
printing::Emf emf;
Emf emf;
EXPECT_TRUE(emf.InitFromData(&data.front(), size));
HDC hdc = CreateCompatibleDC(NULL);
EXPECT_TRUE(hdc);
Expand All @@ -77,15 +77,14 @@ TEST_F(EmfPrintingTest, Enumerate) {
if (IsTestCaseDisabled())
return;

printing::PrintSettings settings;
PrintSettings settings;

// My test case is a HP Color LaserJet 4550 PCL.
settings.set_device_name(L"UnitTest Printer");

// Initialize it.
scoped_ptr<printing::PrintingContext> context(
printing::PrintingContext::Create(std::string()));
EXPECT_EQ(context->InitWithSettings(settings), printing::PrintingContext::OK);
scoped_ptr<PrintingContext> context(PrintingContext::Create(std::string()));
EXPECT_EQ(context->InitWithSettings(settings), PrintingContext::OK);

FilePath emf_file;
EXPECT_TRUE(PathService::Get(base::DIR_SOURCE_ROOT, &emf_file));
Expand All @@ -94,22 +93,22 @@ TEST_F(EmfPrintingTest, Enumerate) {
.Append(FILE_PATH_LITERAL("data"))
.Append(FILE_PATH_LITERAL("test4.emf"));
// Load any EMF with an image.
printing::Emf emf;
Emf emf;
std::string emf_data;
file_util::ReadFileToString(emf_file, &emf_data);
ASSERT_TRUE(emf_data.size());
EXPECT_TRUE(emf.InitFromData(&emf_data[0], emf_data.size()));

// This will print to file. The reason is that when running inside a
// unit_test, printing::PrintingContext automatically dumps its files to the
// unit_test, PrintingContext automatically dumps its files to the
// current directory.
// TODO(maruel): Clean the .PRN file generated in current directory.
context->NewDocument(L"EmfTest.Enumerate");
context->NewPage();
// Process one at a time.
printing::Emf::Enumerator emf_enum(emf, context->context(),
&emf.GetPageBounds(1).ToRECT());
for (printing::Emf::Enumerator::const_iterator itr = emf_enum.begin();
Emf::Enumerator emf_enum(emf, context->context(),
&emf.GetPageBounds(1).ToRECT());
for (Emf::Enumerator::const_iterator itr = emf_enum.begin();
itr != emf_enum.end();
++itr) {
// To help debugging.
Expand All @@ -133,7 +132,7 @@ TEST_F(EmfPrintingTest, PageBreak) {
uint32 size;
std::vector<BYTE> data;
{
printing::Emf emf;
Emf emf;
EXPECT_TRUE(emf.Init());
EXPECT_TRUE(emf.context() != NULL);
int pages = 3;
Expand All @@ -155,7 +154,7 @@ TEST_F(EmfPrintingTest, PageBreak) {
di.cbSize = sizeof(DOCINFO);
di.lpszDocName = L"Test Job";
int job_id = ::StartDoc(dc.Get(), &di);
printing::Emf emf;
Emf emf;
EXPECT_TRUE(emf.InitFromData(&data.front(), size));
EXPECT_TRUE(emf.SafePlayback(dc.Get()));
::EndDoc(dc.Get());
Expand All @@ -178,7 +177,7 @@ TEST(EmfTest, FileBackedEmf) {
uint32 size;
std::vector<BYTE> data;
{
printing::Emf emf;
Emf emf;
EXPECT_TRUE(emf.InitToFile(metafile_path));
EXPECT_TRUE(emf.context() != NULL);
// An empty EMF is invalid, so we put at least a rectangle in it.
Expand All @@ -196,7 +195,7 @@ TEST(EmfTest, FileBackedEmf) {
// Playback the data.
HDC hdc = CreateCompatibleDC(NULL);
EXPECT_TRUE(hdc);
printing::Emf emf;
Emf emf;
EXPECT_TRUE(emf.InitFromFile(metafile_path));
RECT output_rect = {0, 0, 10, 10};
EXPECT_TRUE(emf.Playback(hdc, &output_rect));
Expand Down
4 changes: 3 additions & 1 deletion printing/image.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#include "printing/image.h"

#include <algorithm>

#include "base/file_util.h"
#include "base/md5.h"
#include "base/string_number_conversions.h"
Expand Down Expand Up @@ -146,7 +148,7 @@ bool Image::LoadPng(const std::string& compressed) {

bool Image::LoadMetafile(const std::string& data) {
DCHECK(!data.empty());
printing::NativeMetafile metafile;
NativeMetafile metafile;
if (!metafile.InitFromData(data.data(), data.size()))
return false;
return LoadMetafile(metafile);
Expand Down
4 changes: 2 additions & 2 deletions printing/pdf_metafile_cg_mac_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace printing {

TEST(PdfMetafileCgTest, Pdf) {
// Test in-renderer constructor.
printing::PdfMetafileCg pdf;
PdfMetafileCg pdf;
EXPECT_TRUE(pdf.Init());
EXPECT_TRUE(pdf.context() != NULL);

Expand All @@ -43,7 +43,7 @@ TEST(PdfMetafileCgTest, Pdf) {
pdf.GetData(&buffer.front(), size);

// Test browser-side constructor.
printing::PdfMetafileCg pdf2;
PdfMetafileCg pdf2;
EXPECT_TRUE(pdf2.InitFromData(&buffer.front(), size));

// Get the first 4 characters from pdf2.
Expand Down
2 changes: 1 addition & 1 deletion printing/pdf_metafile_skia.cc
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ PdfMetafileSkia* PdfMetafileSkia::GetMetafileForCurrentPage() {
if (data.size() == 0)
return NULL;

PdfMetafileSkia* metafile = new printing::PdfMetafileSkia;
PdfMetafileSkia* metafile = new PdfMetafileSkia;
metafile->InitFromData(data.bytes(), data.size());
return metafile;
}
Expand Down
94 changes: 47 additions & 47 deletions printing/print_settings.cc
Original file line number Diff line number Diff line change
Expand Up @@ -28,83 +28,83 @@ void GetColorModelForMode(

color_setting_name->assign(kCUPSColorModel);
switch (color_mode) {
case printing::COLOR:
color_value->assign(printing::kColor);
case COLOR:
color_value->assign(kColor);
break;
case printing::CMYK:
color_value->assign(printing::kCMYK);
case CMYK:
color_value->assign(kCMYK);
break;
case printing::PRINTOUTMODE_NORMAL:
color_value->assign(printing::kNormal);
case PRINTOUTMODE_NORMAL:
color_value->assign(kNormal);
color_setting_name->assign(kCUPSPrintoutMode);
break;
case printing::PRINTOUTMODE_NORMAL_GRAY:
color_value->assign(printing::kNormalGray);
case PRINTOUTMODE_NORMAL_GRAY:
color_value->assign(kNormalGray);
color_setting_name->assign(kCUPSPrintoutMode);
break;
case printing::RGB16:
color_value->assign(printing::kRGB16);
case RGB16:
color_value->assign(kRGB16);
break;
case printing::RGBA:
color_value->assign(printing::kRGBA);
case RGBA:
color_value->assign(kRGBA);
break;
case printing::RGB:
color_value->assign(printing::kRGB);
case RGB:
color_value->assign(kRGB);
break;
case printing::CMY:
color_value->assign(printing::kCMY);
case CMY:
color_value->assign(kCMY);
break;
case printing::CMY_K:
color_value->assign(printing::kCMY_K);
case CMY_K:
color_value->assign(kCMY_K);
break;
case printing::BLACK:
color_value->assign(printing::kBlack);
case BLACK:
color_value->assign(kBlack);
break;
case printing::GRAY:
color_value->assign(printing::kGray);
case GRAY:
color_value->assign(kGray);
break;
case printing::COLORMODE_COLOR:
case COLORMODE_COLOR:
color_setting_name->assign(kCUPSColorMode);
color_value->assign(printing::kColor);
color_value->assign(kColor);
break;
case printing::COLORMODE_MONOCHROME:
case COLORMODE_MONOCHROME:
color_setting_name->assign(kCUPSColorMode);
color_value->assign(printing::kMonochrome);
color_value->assign(kMonochrome);
break;
case printing::HP_COLOR_COLOR:
case HP_COLOR_COLOR:
color_setting_name->assign(kColor);
color_value->assign(printing::kColor);
color_value->assign(kColor);
break;
case printing::HP_COLOR_BLACK:
case HP_COLOR_BLACK:
color_setting_name->assign(kColor);
color_value->assign(printing::kBlack);
color_value->assign(kBlack);
break;
case printing::PROCESSCOLORMODEL_CMYK:
case PROCESSCOLORMODEL_CMYK:
color_setting_name->assign(kCUPSProcessColorModel);
color_value->assign(printing::kCMYK);
color_value->assign(kCMYK);
break;
case printing::PROCESSCOLORMODEL_GREYSCALE:
case PROCESSCOLORMODEL_GREYSCALE:
color_setting_name->assign(kCUPSProcessColorModel);
color_value->assign(printing::kGreyscale);
color_value->assign(kGreyscale);
break;
case printing::PROCESSCOLORMODEL_RGB:
case PROCESSCOLORMODEL_RGB:
color_setting_name->assign(kCUPSProcessColorModel);
color_value->assign(printing::kRGB);
color_value->assign(kRGB);
break;
default:
color_value->assign(printing::kGrayscale);
color_value->assign(kGrayscale);
break;
}
}
#endif

bool isColorModelSelected(int model) {
return (model != printing::GRAY &&
model != printing::BLACK &&
model != printing::PRINTOUTMODE_NORMAL_GRAY &&
model != printing::COLORMODE_MONOCHROME &&
model != printing::PROCESSCOLORMODEL_GREYSCALE &&
model != printing::HP_COLOR_BLACK);
return (model != GRAY &&
model != BLACK &&
model != PRINTOUTMODE_NORMAL_GRAY &&
model != COLORMODE_MONOCHROME &&
model != PROCESSCOLORMODEL_GREYSCALE &&
model != HP_COLOR_BLACK);
}

// Global SequenceNumber used for generating unique cookie values.
Expand Down Expand Up @@ -185,16 +185,16 @@ void PrintSettings::SetPrinterPrintableArea(
margins.header = 0;
margins.footer = 0;
margins.top = ConvertUnitDouble(custom_margins_in_points_.top,
printing::kPointsPerInch,
kPointsPerInch,
units_per_inch);
margins.bottom = ConvertUnitDouble(custom_margins_in_points_.bottom,
printing::kPointsPerInch,
kPointsPerInch,
units_per_inch);
margins.left = ConvertUnitDouble(custom_margins_in_points_.left,
printing::kPointsPerInch,
kPointsPerInch,
units_per_inch);
margins.right = ConvertUnitDouble(custom_margins_in_points_.right,
printing::kPointsPerInch,
kPointsPerInch,
units_per_inch);
break;
}
Expand Down
23 changes: 9 additions & 14 deletions printing/print_settings_initializer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

#include <algorithm>
#include <cmath>
#include <string>

#include "base/i18n/time_formatting.h"
#include "base/string_number_conversions.h"
Expand All @@ -19,38 +20,33 @@
#include "ui/base/text/text_elider.h"

using base::DictionaryValue;
using base::Time;
using printing::ConvertPointsToPixelDouble;
using printing::ConvertUnitDouble;
using printing::GetHeaderFooterSegmentWidth;

namespace printing {

void PrintSettingsInitializer::InitHeaderFooterStrings(
const DictionaryValue& job_settings,
PrintSettings* print_settings) {
if (!job_settings.GetBoolean(printing::kSettingHeaderFooterEnabled,
if (!job_settings.GetBoolean(kSettingHeaderFooterEnabled,
&print_settings->display_header_footer)) {
NOTREACHED();
}
if (!print_settings->display_header_footer)
return;

string16 date = base::TimeFormatShortDateNumeric(Time::Now());
string16 date = base::TimeFormatShortDateNumeric(base::Time::Now());
string16 title;
std::string url;
if (!job_settings.GetString(printing::kSettingHeaderFooterTitle, &title) ||
!job_settings.GetString(printing::kSettingHeaderFooterURL, &url)) {
if (!job_settings.GetString(kSettingHeaderFooterTitle, &title) ||
!job_settings.GetString(kSettingHeaderFooterURL, &url)) {
NOTREACHED();
}

gfx::Font font(UTF8ToUTF16(printing::kSettingHeaderFooterFontName),
ceil(ConvertPointsToPixelDouble(
printing::kSettingHeaderFooterFontSize)));
gfx::Font font(
UTF8ToUTF16(kSettingHeaderFooterFontName),
ceil(ConvertPointsToPixelDouble(kSettingHeaderFooterFontSize)));
double segment_width = GetHeaderFooterSegmentWidth(ConvertUnitDouble(
print_settings->page_setup_device_units().physical_size().width(),
print_settings->device_units_per_inch(),
printing::kPixelsPerInch));
print_settings->device_units_per_inch(), kPixelsPerInch));
date = ui::ElideText(date, font, segment_width, false);
print_settings->date = date;

Expand All @@ -69,4 +65,3 @@ void PrintSettingsInitializer::InitHeaderFooterStrings(
}

} // namespace printing

5 changes: 2 additions & 3 deletions printing/printed_document_mac.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,11 @@ void PrintedDocument::RenderPrintedPage(

DCHECK(context);

const printing::PageSetup& page_setup(
immutable_.settings_.page_setup_device_units());
const PageSetup& page_setup(immutable_.settings_.page_setup_device_units());
gfx::Rect content_area;
page.GetCenteredPageContentRect(page_setup.physical_size(), &content_area);

const printing::Metafile* metafile = page.metafile();
const Metafile* metafile = page.metafile();
// Each Metafile is a one-page PDF, and pages use 1-based indexing.
const int page_number = 1;
metafile->RenderPage(page_number, context, content_area.ToCGRect(),
Expand Down
3 changes: 1 addition & 2 deletions printing/printed_document_win.cc
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ void PrintedDocument::RenderPrintedPage(

DCHECK(context);

const printing::PageSetup& page_setup(
immutable_.settings_.page_setup_device_units());
const PageSetup& page_setup(immutable_.settings_.page_setup_device_units());
gfx::Rect content_area;
page.GetCenteredPageContentRect(page_setup.physical_size(), &content_area);

Expand Down
Loading

0 comments on commit d91db11

Please sign in to comment.