Skip to content

Commit

Permalink
Declare dependency on blink_headers in targets that use blink headers
Browse files Browse the repository at this point in the history
This updates targets that use blink public API headers to depend on the
blink_headers target, which sets up include paths so the headers can function
without needing relative path hacks. Targets that expose #includes of public
blink headers export the dependent settings from blink_headers to their
dependents.

BUG=350097

Review URL: https://codereview.chromium.org/189713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257357 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
jamesr@chromium.org committed Mar 16, 2014
1 parent dd48d49 commit 312c58b
Show file tree
Hide file tree
Showing 14 changed files with 41 additions and 4 deletions.
1 change: 1 addition & 0 deletions chrome/chrome.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@
'common/extensions/api/api.gyp:chrome_api',
'../base/base.gyp:base',
'../components/components.gyp:wifi_component',
'../content/content.gyp:content_common',
'../content/content.gyp:content_utility',
'../media/media.gyp:media',
'../skia/skia.gyp:skia',
Expand Down
1 change: 1 addition & 0 deletions chrome/chrome_browser.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
],
'export_dependent_settings': [
'../components/components.gyp:autofill_core_browser',
'../content/content.gyp:content_browser',
'../sql/sql.gyp:sql',
'../sync/sync.gyp:sync',
],
Expand Down
3 changes: 3 additions & 0 deletions chrome/chrome_browser_extensions.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@
'..',
'<(INTERMEDIATE_DIR)',
],
'export_dependent_settings': [
'../content/content.gyp:content_browser',
],
'sources': [
# All .cc, .h, .m, and .mm files under browser/extensions except for
# tests and mocks.
Expand Down
3 changes: 3 additions & 0 deletions chrome/chrome_tests.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -2351,6 +2351,9 @@
'<(protoc_out_dir)',
],
},
'export_dependent_settings': [
'browser',
],
'sources': [
'browser/sync/test/integration/apps_helper.cc',
'browser/sync/test/integration/apps_helper.h',
Expand Down
1 change: 1 addition & 0 deletions chrome/common/extensions/api/api.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@
'root_namespace': 'extensions::api',
},
'dependencies': [
'<(DEPTH)/content/content.gyp:content_browser',
'<(DEPTH)/skia/skia.gyp:skia',
'<(DEPTH)/sync/sync.gyp:sync',
],
Expand Down
1 change: 1 addition & 0 deletions components/dom_distiller.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@
'component_resources.gyp:component_resources',
'component_strings.gyp:component_strings',
'dom_distiller_core',
'../content/content.gyp:content_browser',
'../net/net.gyp:net',
'../skia/skia.gyp:skia',
'../sync/sync.gyp:sync',
Expand Down
3 changes: 3 additions & 0 deletions components/nacl.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,9 @@
'include_dirs': [
'..',
],
'dependencies': [
'../content/content.gyp:content_common',
],
},
]
}
7 changes: 7 additions & 0 deletions content/content.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@
'dependencies': [
'content_common',
],
'export_dependent_settings': [
'content_common',
],
},
{
'target_name': 'content_browser',
Expand Down Expand Up @@ -337,18 +340,21 @@
'target_name': 'content_app_both',
'type': 'none',
'dependencies': ['content'],
'export_dependent_settings': ['content'],
},
{
'target_name': 'content_browser',
'type': 'none',
'dependencies': ['content'],
'export_dependent_settings': ['content'],
},
{
'target_name': 'content_common',
'type': 'none',
'dependencies': ['content', 'content_resources.gyp:content_resources'],
# Disable c4267 warnings until we fix size_t to int truncations.
'msvs_disabled_warnings': [ 4267, ],
'export_dependent_settings': ['content'],
},
{
'target_name': 'content_child',
Expand Down Expand Up @@ -381,6 +387,7 @@
'target_name': 'content_utility',
'type': 'none',
'dependencies': ['content'],
'export_dependent_settings': ['content'],
},
{
'target_name': 'content_worker',
Expand Down
5 changes: 5 additions & 0 deletions content/content_browser.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
'../third_party/re2/re2.gyp:re2',
'../third_party/zlib/google/zip.gyp:zip',
'../third_party/zlib/zlib.gyp:zlib',
'../third_party/WebKit/public/blink_headers.gyp:blink_headers',
'../ui/accessibility/accessibility.gyp:accessibility',
'../ui/accessibility/accessibility.gyp:ax_gen',
'../ui/base/ui_base.gyp:ui_base',
Expand All @@ -26,6 +27,10 @@
],
'export_dependent_settings': [
'../ui/accessibility/accessibility.gyp:ax_gen',
# The public content API headers directly include Blink API headers, so we
# have to export the blink header settings so that relative paths in these
# headers resolve correctly.
'../third_party/WebKit/public/blink_headers.gyp:blink_headers',
],
'include_dirs': [
'..',
Expand Down
5 changes: 5 additions & 0 deletions content/content_common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
'../components/tracing.gyp:tracing',
'../net/net.gyp:net',
'../skia/skia.gyp:skia',
'../third_party/WebKit/public/blink_headers.gyp:blink_headers',
'../third_party/icu/icu.gyp:icuuc',
'../third_party/libjingle/libjingle.gyp:libjingle',
'../ui/accessibility/accessibility.gyp:accessibility',
Expand All @@ -22,6 +23,10 @@
],
'export_dependent_settings': [
'../base/base.gyp:base',
# The public content API headers directly include Blink API headers, so we
# have to export the blink header settings so that relative paths in these
# headers resolve correctly.
'../third_party/WebKit/public/blink_headers.gyp:blink_headers',
],
'sources': [
'public/common/assert_matching_enums.cc',
Expand Down
1 change: 1 addition & 0 deletions content/content_ppapi_plugin.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
'../ui/base/ui_base.gyp:ui_base',
'../ui/gfx/gfx.gyp:gfx',
'../ui/gfx/gfx.gyp:gfx_geometry',
'../third_party/WebKit/public/blink.gyp:blink',
],
'sources': [
'ppapi_plugin/broker_process_dispatcher.cc',
Expand Down
1 change: 1 addition & 0 deletions content/content_tests.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -901,6 +901,7 @@
'type': 'static_library',
'dependencies': [
'content_shell_lib',
'content.gyp:content_browser',
'../skia/skia.gyp:skia',
'../testing/gtest.gyp:gtest',
'../ui/accessibility/accessibility.gyp:ax_gen',
Expand Down
9 changes: 5 additions & 4 deletions ppapi/ppapi_proxy_nacl.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,20 @@
'..',
],
'dependencies': [
'../native_client/tools.gyp:prep_toolchain',
'../base/base_nacl.gyp:base_nacl',
'../components/tracing_nacl.gyp:tracing_nacl',
'../gpu/command_buffer/command_buffer_nacl.gyp:gles2_utils_nacl',
'../gpu/gpu_nacl.gyp:command_buffer_client_nacl',
'../gpu/gpu_nacl.gyp:command_buffer_common_nacl',
'../gpu/gpu_nacl.gyp:gles2_implementation_nacl',
'../gpu/gpu_nacl.gyp:gles2_cmd_helper_nacl',
'../gpu/gpu_nacl.gyp:gles2_implementation_nacl',
'../gpu/gpu_nacl.gyp:gpu_ipc_nacl',
'../ipc/ipc_nacl.gyp:ipc_nacl',
'../ppapi/ppapi_shared_nacl.gyp:ppapi_shared_nacl',
'../native_client/tools.gyp:prep_toolchain',
'../ppapi/ppapi_ipc_nacl.gyp:ppapi_ipc_nacl',
'../ppapi/ppapi_shared_nacl.gyp:ppapi_shared_nacl',
'../third_party/WebKit/public/blink_headers.gyp:blink_headers',
'../third_party/khronos/khronos.gyp:khronos_headers',
'../components/tracing_nacl.gyp:tracing_nacl',
],
},
],
Expand Down
4 changes: 4 additions & 0 deletions webkit/common/webkit_common.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@
'<(DEPTH)/ui/resources/ui_resources.gyp:ui_resources',
'<(DEPTH)/url/url.gyp:url_lib',
'<(DEPTH)/webkit/webkit_resources.gyp:webkit_resources',
'<(DEPTH)/third_party/WebKit/public/blink_headers.gyp:blink_headers',
],
'export_dependent_settings': [
'<(DEPTH)/third_party/WebKit/public/blink_headers.gyp:blink_headers',
],

'include_dirs': [
Expand Down

0 comments on commit 312c58b

Please sign in to comment.