Prevent from unhandled promise rejection durning workbook load#1087
Merged
alubbe merged 1 commit intoexceljs:masterfrom Jan 21, 2020
sohai:master
Merged
Prevent from unhandled promise rejection durning workbook load#1087alubbe merged 1 commit intoexceljs:masterfrom sohai:master
alubbe merged 1 commit intoexceljs:masterfrom
sohai:master
Conversation
Siemienik
approved these changes
Jan 21, 2020
alubbe
approved these changes
Jan 21, 2020
Member
|
Good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #829
StreamBuf.writereturns Promise, that leads to unhandled promise rejection inWorkbook.loadbecauseZipStream.writedo not expectStreamBuf.writeto return Promise.