Skip to content

User specified database cleanup #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

exa-mn
Copy link

@exa-mn exa-mn commented Nov 11, 2022

No description provided.

Comment on lines +8 to +9

@Test

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Test
@Test

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

.build();

CLEANER.cleanDatabase(request);
assertDoesNotThrow(this::createSchema);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests only if the object is deleted, not if the other ones are untouched. 50% done. :-)

Copy link

@redcatbear redcatbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests test only one aspect of the desired behavior and that is what should be deleted. They are not testing what should not be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants