Fix GCMapAllocator not being used #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @seanfarley on file. In order for us to review and merge your code, please email info@exaloop.io to get yourself added. |
seanfarley
force-pushed
the
cxx-allocator-fix
branch
from
8e78c05 to
332ef12
Compare
|
Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @seanfarley on file. In order for us to review and merge your code, please email info@exaloop.io to get yourself added. |
|
Should be able to run the CI now... |
seanfarley
force-pushed
the
cxx-allocator-fix
branch
from
332ef12 to
db63c1b
Compare
seanfarley
force-pushed
the
cxx-allocator-fix
branch
from
db63c1b to
42ad9ab
Compare
Previously, the GCMapAllocator specified the wrong template arguments
and, thus, would not actually be used. This can be verified by the fact
that `GCMapAllocator::deallocate` used an undefined symbol:
`seq_gc_free`.
C++20 makes this an error like so:
```
error: static assertion failed due to requirement 'is_same<GCMapAllocator<std::pair<seq_str_t, long long>, re2::RE2>, GCMapAllocator<std::pair<const std::pair<seq_str_t, long long>, re2::RE2>, re2::RE2>>::value': [allocator.requirements] states that rebinding an allocator to the same type should result in the original allocator
static_assert(is_same<allocator_type, __rebind_alloc<__alloc_traits, value_type> >::value,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
```
This patch fixes the undefined symbol of `seq_gc_free` with `seq_free`
along with fixing `<Key, Value>` -> `<std::pair<Key, Value>>`.
seanfarley
force-pushed
the
cxx-allocator-fix
branch
from
42ad9ab to
4d5410a
Compare
|
I just pushed a small fixup for compiling on linux (I think an issue with libstdc+). Sorry for missing this the first time. |
|
Thanks @seanfarley! I'll go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the GCMapAllocator specified the wrong template arguments and, thus, would not actually be used. This can be verified by the fact that
GCMapAllocator::deallocateused an undefined symbol:seq_gc_free.C++20 makes this an error like so:
This patch fixes the undefined symbol of
seq_gc_freewithseq_freealong with fixing<Key, Value>-><std::pair<Key, Value>>.