Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object file generation #192

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

learnforpractice
Copy link
Contributor

Make sure object file generation command like below works:

codon build --obj --march=wasm32 -o a.o a.codon

@cla-bot
Copy link

cla-bot bot commented Feb 2, 2023

Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @learnforpractice on file. In order for us to review and merge your code, please email info@exaloop.io to get yourself added.

@cla-bot cla-bot bot added the cla-signed label Feb 3, 2023
@arshajii
Copy link
Contributor

arshajii commented Feb 3, 2023

Thanks a lot for the PR -- this looks good to me. Can we please do the following:

  • Since we're moving the llvm/CodeGen/CommandFlags.h include to llvm.h, can we delete it from the following files: codon/cir/llvm/gpu.cpp, codon/cir/llvm/llvisitor.cpp and codon/cir/llvm/optimize.cpp. (There used to be some issue with this include in older LLVM versions, which is why it was done this way originally.)

  • Run clang-format (i.e. clang-format --style=file -i <changed files>) (should alphabetize llvm.h includes)

@arshajii arshajii merged commit 28ebb2e into exaloop:develop Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants