fix #45 #46
Merged
fix #45 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This would always be false, which is why the secondary opt was not added to the opt_str
|
Great stuff, thanks! I have a feeling I put the idx stuff in because there can be multiple pairs of these flags (you can define lots of alternatives for the same option) and we need to show the right one. But if this fixes the behaviour then I guess you've isolated where the bug is 👌🏻 I'll take a look ASAP. |
ewels
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Thanks again for this! I refactored slightly to use a try/except with the assumption that this is the kind of safety mechanism that I was aiming for when I originally wrote the code.
In my testing I couldn't get it to trigger so I'm not sure that it is needed, but I figure it doesn't hurt either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45. Not sure if there is more to be considered here, since I am not really familiar with the inner workings of
click.