Sidecar #148
Merged
Sidecar #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mipieta
force-pushed
the
sidecar
branch
4 times, most recently
from
2562f1c
to
5bfe973
Compare
JeraldStarr
approved these changes
Jul 22, 2024
lukasz-wojcik-14
approved these changes
Jul 22, 2024
knutia
requested changes
Aug 21, 2024
java/values.yaml
Outdated
Comment on lines
16
to
58
| sidecars: | ||
| - name: helper1 | ||
| image: | ||
| repository: "repo" | ||
| tag: "123" | ||
| extraContainerPorts: [8088, 9099] | ||
| securityContext: | ||
| readOnlyRootFilesystem: true | ||
| allowPrivilegeEscalation: false | ||
| resources: | ||
| limits: | ||
| cpu: 100m | ||
| memory: 128Mi | ||
| requests: | ||
| cpu: 100m | ||
| memory: 128Mi | ||
| environment: { } | ||
| secrets: { } | ||
| volumeMounts: [ ] | ||
| # - name: secret-volume | ||
| # mountPath: /app/secrets | ||
| # readOnly: true | ||
| - name: helper2 | ||
| image: | ||
| repository: "repo" | ||
| tag: "456" | ||
| extraContainerPorts: [8088, 9099] | ||
| securityContext: | ||
| readOnlyRootFilesystem: true | ||
| allowPrivilegeEscalation: false | ||
| resources: | ||
| limits: | ||
| cpu: 100m | ||
| memory: 128Mi | ||
| requests: | ||
| cpu: 100m | ||
| memory: 128Mi | ||
| environment: { } | ||
| secrets: { } | ||
| volumeMounts: | ||
| - name: secret-volume | ||
| mountPath: /app/secrets | ||
| readOnly: true |
There was a problem hiding this comment.
This will force everyone using this chart to use this settings. If they do not explicit override or give a null value they will get this values. There is other company's using this helm chart so this is no go. use sidecars: {} as value and comment out the "example" (see csi: {})
There was a problem hiding this comment.
Thank you for noticing that. Now it should do the job. Please check again.
libchart/values.yaml
Outdated
Comment on lines
17
to
59
| sidecars: | ||
| - name: helper1 | ||
| image: | ||
| repository: "repo" | ||
| tag: "123" | ||
| extraContainerPorts: [8088, 9099] | ||
| securityContext: | ||
| readOnlyRootFilesystem: true | ||
| allowPrivilegeEscalation: false | ||
| resources: | ||
| limits: | ||
| cpu: 100m | ||
| memory: 128Mi | ||
| requests: | ||
| cpu: 100m | ||
| memory: 128Mi | ||
| environment: { } | ||
| secrets: { } | ||
| volumeMounts: [ ] | ||
| # - name: secret-volume | ||
| # mountPath: /app/secrets | ||
| # readOnly: true | ||
| - name: helper2 | ||
| image: | ||
| repository: "repo" | ||
| tag: "456" | ||
| extraContainerPorts: [8088, 9099] | ||
| securityContext: | ||
| readOnlyRootFilesystem: true | ||
| allowPrivilegeEscalation: false | ||
| resources: | ||
| limits: | ||
| cpu: 100m | ||
| memory: 128Mi | ||
| requests: | ||
| cpu: 100m | ||
| memory: 128Mi | ||
| environment: { } | ||
| secrets: { } | ||
| volumeMounts: | ||
| - name: secret-volume | ||
| mountPath: /app/secrets | ||
| readOnly: true |
There was a problem hiding this comment.
This will force everyone using this chart to use this settings. If they do not explicit override or give a null value they will get this values. There is other company's using this helm chart so this is no go. use sidecars: {} as value and comment out the "example" (see csi: {})
knutia
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
Issues this PR fixes
Fixes #