Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pdb api version to v1 #143

Merged
merged 2 commits into from
May 4, 2023
Merged

Change pdb api version to v1 #143

merged 2 commits into from
May 4, 2023

Conversation

Artlvns
Copy link
Contributor

@Artlvns Artlvns commented May 4, 2023

Description

PDB API version policy/v1beta1 is deprecated in Kubernetes v1.21.0 and deleted in v1.25.0.
Replacement is policy/v1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [x ] Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have made design choices.
  • My design choices are documented in an Architecture Decision Record in the designated ARD folder of this repo.

Issues this PR fixes

Fixes #

@Artlvns Artlvns requested a review from ekarlso May 4, 2023 10:14
@ekarlso
Copy link
Contributor

ekarlso commented May 4, 2023

You need to bump all major versions also in charts.

Copy link
Contributor

@ekarlso ekarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Artlvns Artlvns merged commit 6a96e25 into master May 4, 2023
@Artlvns Artlvns deleted the pdb-depricated-api-ver branch May 4, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants