Switch to use libchart approach to avoid code duplication

[ekarlso]

No description provided.

[ahm81]

sjekk også i linje 7 på java/templates/NOTES.txt

[Haavare]

When the comments are resolved this looks good

[ahm81]

@ekarlso Etter å ha sjekket nøyere etter så lurer jeg på om du generer duplikater siden du både har templates mappen for hvert språk og har tillegg templates mappen med samme tingene i libchart

[Haavare]

I can't se any duplicated *.yaml files, the _*.tpl files will not create files of their own.

[Haavare]

@ekarlso you have to run helm dependency update to import the libchart tar file into /charts

helm package bundles the tar file

[Haavare]

here is a example of helm template libchart-test ./dotnet/ after importing the libchar tar file:

---
# Source: dotnet/templates/service-account.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: libchart-test-dotnet
  namespace: marine-resources-prod
  labels:
    helm.sh/chart: dotnet-9.0.0

    app.kubernetes.io/name: libchart-test
    app.kubernetes.io/instance: libchart-test

    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/part-of: libchart-test
    app.kubernetes.io/component: libchart-test
---
# Source: dotnet/templates/service.yaml
apiVersion: v1
kind: Service
metadata:
  name: libchart-test
  namespace: marine-resources-prod
  labels:
    helm.sh/chart: dotnet-9.0.0

    app.kubernetes.io/name: libchart-test
    app.kubernetes.io/instance: libchart-test

    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/part-of: libchart-test
    app.kubernetes.io/component: libchart-test
spec:
  type: ClusterIP
  ports:
    - port: 80
      targetPort: 8080
      protocol: TCP
      name: http

  selector:

    app.kubernetes.io/name: libchart-test
    app.kubernetes.io/instance: libchart-test
---
# Source: dotnet/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: libchart-test
  namespace: marine-resources-prod
  labels:
    helm.sh/chart: dotnet-9.0.0

    app.kubernetes.io/name: libchart-test
    app.kubernetes.io/instance: libchart-test

    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/part-of: libchart-test
    app.kubernetes.io/component: libchart-test
spec:
  replicas: 1
  selector:
    matchLabels:

      app.kubernetes.io/name: libchart-test
      app.kubernetes.io/instance: libchart-test
  template:
    metadata:
      labels:
        helm.sh/chart: dotnet-9.0.0

        app.kubernetes.io/name: libchart-test
        app.kubernetes.io/instance: libchart-test

        app.kubernetes.io/managed-by: Helm
        app.kubernetes.io/part-of: libchart-test
        app.kubernetes.io/component: libchart-test
    spec:

      serviceAccountName: libchart-test-dotnet
      securityContext:
        runAsNonRoot: true
      containers:
        - name: dotnet
          image: ":"
          imagePullPolicy: Always
          ports:
            - name: http
              containerPort: 8080
              protocol: TCP

          livenessProbe:
            httpGet:
              path: /
              port: 8080
            initialDelaySeconds: 15
            timeoutSeconds: 15
            periodSeconds: 15
          readinessProbe:
            httpGet:
              path: /
              port: 8080
            initialDelaySeconds: 15
            timeoutSeconds: 15
            periodSeconds: 15
          env:
          resources:

            {}
      affinity:
        podAntiAffinity:
          preferredDuringSchedulingIgnoredDuringExecution:
            - weight: 1
              podAffinityTerm:
                topologyKey: "kubernetes.io/hostname"
                labelSelector:
                  matchLabels:

                    app.kubernetes.io/name: libchart-test
                    app.kubernetes.io/instance: libchart-test
---
# Source: dotnet/templates/servicemonitor.yaml
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: libchart-test
  namespace: marine-resources-prod
  labels:
    helm.sh/chart: dotnet-9.0.0

    app.kubernetes.io/name: libchart-test
    app.kubernetes.io/instance: libchart-test

    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/part-of: libchart-test
    app.kubernetes.io/component: libchart-test
    prometheus: default
spec:
  selector:
    matchLabels:

      app.kubernetes.io/name: libchart-test
      app.kubernetes.io/instance: libchart-test
  endpoints:
  - path: /metrics
    interval: 15s
    targetPort: 8080
    honorLabels: true

I do not know if this is a good example

[Haavare]

I think this is a good examle of a situation where Architecture Decision Records would make sense to have:
https://cognitect.com/blog/2011/11/15/documenting-architecture-decisions

At the moment I am not sure why libchart is considered less complex than maintaining separate charts

[ekarlso]

I think this is a good examle of a situation where Architecture Decision Records would make sense to have:
https://cognitect.com/blog/2011/11/15/documenting-architecture-decisions

At the moment I am not sure why libchart is considered less complex than maintaining separate charts

Because now implementing a change or a common component is at least common across them all ;)

Whether we should actually have seperate charts for java, dotnet, or whatever language you think if is a better valid question in my mind.

[Haavare]

Yes, I actually thought you all decided only the web chart was necessary two years ago

[Haavare]

There are namespace in some but not all templates, I do not think we need them, but could we be consistent either or.

[ekarlso]

There are namespace in some but not all templates, I do not think we need them, but could we be consistent either or.

Removed namespaces and now and added policy to keep it removed :

[Haavare]

You check if it is a statefulset twice, on include and define. I think that is fine.
I am not familiar with the Istio templates, so I just checke spelling.
Otherwise did you see my comment on labelSelectors? That is the only thing I have left, great work!

[ekarlso]

You check if it is a statefulset twice, on include and define. I think that is fine.
I am not familiar with the Istio templates, so I just checke spelling.
Otherwise did you see my comment on labelSelectors? That is the only thing I have left, great work!

Where's this?

[ahm81]

Good work @ekarlso!

[Haavare]

You check if it is a statefulset twice, on include and define. I think that is fine.
I am not familiar with the Istio templates, so I just checke spelling.
Otherwise did you see my comment on labelSelectors? That is the only thing I have left, great work!

Where's this?

Looks like you have changed it, all good