Allow serving frontend via backend #1492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying bracket-docs with
|
| Latest commit: |
b4d98bd
|
| Status: | ⚡️ Build in progress... |
Deploying bracket-frontend with
|
| Latest commit: |
7c6ef2c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82109ef6.bracket-abd.pages.dev |
| Branch Preview URL: | https://allow-serving-frontend-via-b.bracket-abd.pages.dev |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1492 +/- ##
==========================================
- Coverage 94.94% 94.77% -0.17%
==========================================
Files 120 120
Lines 4350 4363 +13
==========================================
+ Hits 4130 4135 +5
- Misses 220 228 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
|
I fixed the security vulnerability but CodeQL keeps complaining no matter what I do.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to run Bracket in development/simple production environments because you only need to run 1 Docker container. Also, it avoids CORS problems because the frontend and backend run on the same domain.