Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license and add a basic contribution guide #359

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

MGaetan89
Copy link
Contributor

As discussed in #326, this PR unify the project license to use MIT.

I've also added a basic contribution guide. The extra suggestions in #326 (comment) can be addressed in a separate PR, but adding Pull Request and Issues templates to the project.

@@ -1,20 +0,0 @@
TableView contributors (sorted alphabetically)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've replaced this file with a link to GitHub's contributors' list, so there no need to manually maintain a file. Let me know if you prefer to keep this file.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is that GitHub's contributors' list, only covers direct contributions and not those pulled in from forks.

- (contact me to mention your app on this page)


## Communication
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this section has moved to the CONTRIBUTING.md file

@evrencoskun
Copy link
Owner

Looks fine Thanks @MGaetan89

@evrencoskun evrencoskun merged commit ca0fdb5 into evrencoskun:master Jan 19, 2021
@MGaetan89 MGaetan89 deleted the update_license branch January 19, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants