Add option to display the Corner View when there are Column headers but no rows or cells #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 29, 2020 12:59
…laying the corner view. Added optional method to display corner view if there are some column headers but not row headers or cells Optimised the condition logic for displaying/hiding corner view
Enable Jacoco Code Coverage on tableview Instrumented Tests by running "createDebugCoverageReport" gradle tasks
Add tests for when setShowCornerView = true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the issue #308
It adds the flag to tableview
tableView.setShowCornerView(true);to change the behaviour ofsetAllItemsin the adaptor.It also adds automated test instrumented test infrastructure to the tableview to test the behaviour change.
The test infrastructure is based on ideas of how androidx recyclerview and it's layout managers are tested and how flexbox layout manager is tested.
Code Coverage for these tests is also enabled (created by running the "createDebugCoverageReport" gradle task in the "tableview" module)
The non "ShowCorner" set of test were developed before "ShowCorner" feature was developed and all passed.
Code Coverage report before feature for
setAllItemsNote some branches not covered as the tests only target the "Is not empty" not the "is not null" condition checks.
Test results after the "ShowCorner" feature
Code Coverage report after feature changes for
setAllItemsThese tests passed on emulators API 22 and API 29 (Note Instrumented tests are note available before API 21 so cannot be used to cover down to the minimum specified API of 14)
Manual test of the sample app showed no change as this does not exhibit the conditions where the feature changes the behaviour (the sample app also does not enable the feature)