Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overriding global method for all :sql-jdbc drivers #18

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix overriding global method for all :sql-jdbc drivers #18

merged 1 commit into from
Jul 18, 2023

Conversation

camsaul
Copy link
Contributor

@camsaul camsaul commented Jul 14, 2023

The :firebird driver implements sql-jdbc.sync/have-select-privilege? for :sql-jdbc rather than :firebird which ultimately breaks the method for other drivers like Postgres, for example

metabase/metabase#32124

@camsaul camsaul mentioned this pull request Jul 14, 2023
Closed
@dodgex dodgex requested a review from Nikos410 July 14, 2023 21:22
@Nikos410
Copy link
Member

Whoops, missed that in #15. Thanks for the heads-up and for the fix @camsaul :)

@Nikos410 Nikos410 merged commit 1cc14a8 into evosec:develop Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nikos410 Nikos410 Nikos410 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camsaul @Nikos410