Skip to content

Commit

Permalink
feat(AP-3058)!: drop conventionalcommits preset, just follow angular …
Browse files Browse the repository at this point in the history
…conventions (#51)

the angular conventions for conventional-commits do not respect the "!" flag to indicate a major version bump. however, the following line can use be used to indicate such

BREAKING CHANGE: upgraded to react@18 and next@13
  • Loading branch information
mattstrom authored Jul 31, 2023
1 parent 76e5041 commit e8cc5bf
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 25 deletions.
1 change: 0 additions & 1 deletion .github/workflows/on-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ jobs:
- name: Tag
run: |
npm install --global conventional-changelog-conventionalcommits
npx --yes -- lerna version --yes
- name: Save commit SHA
Expand Down
1 change: 0 additions & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"version": {
"allowBranch": "main",
"conventionalCommits": true,
"changelogPreset": "conventionalcommits",
"message": "chore(release): publish %v",
"private": false
},
Expand Down
22 changes: 0 additions & 22 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
"@evolv/eslint-config": "^1.1.3",
"@types/jest": "^29.0.1",
"@types/node": "^18.7.16",
"conventional-changelog-conventionalcommits": "^6.1.0",
"del-cli": "^5.0.0",
"eslint": "8.22.0",
"eslint-config-next": "^12.3.0",
Expand Down

0 comments on commit e8cc5bf

Please sign in to comment.