Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework UpdateResult #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rework UpdateResult #110

wants to merge 1 commit into from

Conversation

edubrovski
Copy link
Contributor

Motivation: currently UpdateResult has an updated flag, but it's impossible for users of Conhub to know why a certain update operation has failed.

@edubrovski edubrovski requested review from t3hnar and theide July 4, 2023 11:52
@coveralls
Copy link

coveralls commented Jul 4, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5454622325

  • 19 of 20 (95.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 31.401%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/scala/com/evolutiongaming/conhub/ConStates.scala 19 20 95.0%
Files with Coverage Reduction New Missed Lines %
src/main/scala/com/evolutiongaming/conhub/ConStates.scala 1 82.81%
src/main/scala/com/evolutiongaming/conhub/transport/SendMsg.scala 1 5.37%
Totals Coverage Status
Change from base Build 5446366943: -0.4%
Covered Lines: 130
Relevant Lines: 414
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3hnar t3hnar Awaiting requested review from t3hnar

@theide theide Awaiting requested review from theide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edubrovski @coveralls