Add FFI bindings for the libcurl URL parsing APIs #653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs benchmarking to determine whether the overhead is significant. If yes, also create a C++ wrapper.Preliminary results from a few simple/throwaway microbenchmarks suggest:
Regarding size limits:
Although libcurl claims to support up to 8MB for each URL component, that limit seems impractically high. I've therefore limited my testing to the more sensible range of up to 2 KB max. At this point it seems that the actual time is dominated by allocations and cleanup (free), which isn't yet optimized but should be - see note below.
Semi-related:
The built-in allocator should be integrated with libcurl in any event, same as for some of the other libraries, but that's something of a future concern. Libcurl does offer an API to do it, but that's not currently being used.
Basically, it doesn't seem worth optimizing these bindings right now. Allocations are already on my (long) list.