Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise TypeError for nonexistent fragment. Add basic isort config #146

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Raise TypeError for nonexistent fragment. Add basic isort config #146

merged 3 commits into from
Dec 21, 2023

Conversation

skovbasa
Copy link
Collaborator

@skovbasa skovbasa commented Dec 20, 2023 •
edited
Loading

Fixes queries with non-existent fragments failing with KeyError. Wrapped these with TypeError for correct query validation

@skovbasa skovbasa requested a review from kindermax December 20, 2023 21:45
@skovbasa
Copy link
Collaborator Author

skovbasa commented Dec 20, 2023 •
edited
Loading

Also replaced setup-pdm action with pip install, cause last pdm version does not support python3.7 🙃 (the version is hardcoded into setup script)

If there is a better solution - I am all for it

@kindermax
Copy link
Collaborator

kindermax commented Dec 21, 2023 •
edited
Loading

setup-pdm to pip install

it is fine although action has the ability to specify pdm version as well https://github.com/pdm-project/setup-pdm?tab=readme-ov-file#action-inputs

@kindermax kindermax merged commit 64fd267 into master Dec 21, 2023
@kindermax kindermax deleted the add-checks-for-nonexistent-fragment branch December 21, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermax kindermax kindermax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skovbasa @kindermax