Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(build): added build-reproducible to makefile #143

Merged
merged 4 commits into from
Dec 3, 2021

Conversation

prajjwol
Copy link
Contributor

@prajjwol prajjwol commented Dec 2, 2021

Closes: #ENG-324

Description

  • Update Makefile to include build-reproducible
  • Added documentation for build-reproducible

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* release(evmos): Update CHANGELOG

* Update CHANGELOG.md

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
@prajjwol prajjwol force-pushed the prajjwol/eng-324_reproducible_builds branch from 8d321da to 9d4728c Compare December 2, 2021 23:04
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@fedekunze fedekunze enabled auto-merge (squash) December 3, 2021 11:06
@fedekunze fedekunze merged commit 357e8fa into main Dec 3, 2021
@fedekunze fedekunze deleted the prajjwol/eng-324_reproducible_builds branch December 3, 2021 11:08
jolube added a commit that referenced this pull request Dec 8, 2021
* docs(evmos): update latest version to v0.4.0 (#139)

* docs: change `ethermintd` -> `evmosd` (#142)

* docs: migrate cosmovisor and genesis validator instructions (#141)

* docs(evmos): Add upgrade node with cosmovisor instructions

* docs(evmos): Add Incorporate changes from Cosmos Hub Vega Upgrade

* Apply suggestions from code review

* go mod tidy

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

* build: added build-reproducible to Makefile (#143)

* release: v0.4.0 changelog (#138)

* release(evmos): Update CHANGELOG

* Update CHANGELOG.md

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* (build): added build-reproducible to makefile

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

* docs: Add link to consensus problems if you don't upgrade your node (#146)

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* deps: bump SDK version (#147)

* deps: bump SDK version

* norace

* build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150)

Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: mergify changes (#152)

* Fix `evmosd version`  (#151)

* build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150)

Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build fix evmosd command

* Update CHANGELOG.md

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* app: fix typo in calculation of failed transactions in TPS value (#149)

Noticed while I was auditing through evmosd code that inside
the code that records TPS, that we have a typo in the calculation
of nFailed, that instead used latestNSuccessful, of which if enough
time is spent and the successful transactions have grown, while
the number of failed transactions stays still, this can cause
wrong TPS values to be reported.

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* Update .goreleaser.yml (#156)

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: Rohit Durvasula <88731568+rohitbison@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>
Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
faddat referenced this pull request in notional-labs/evmos Dec 9, 2021
fixes #118

don't sign unit test tx

since that's the same case as real tx

comment EthValidateBasicDecorator
jolube added a commit that referenced this pull request Dec 11, 2021
* docs(evmos): update latest version to v0.4.0 (#139)

* docs: change `ethermintd` -> `evmosd` (#142)

* docs: migrate cosmovisor and genesis validator instructions (#141)

* docs(evmos): Add upgrade node with cosmovisor instructions

* docs(evmos): Add Incorporate changes from Cosmos Hub Vega Upgrade

* Apply suggestions from code review

* go mod tidy

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

* build: added build-reproducible to Makefile (#143)

* release: v0.4.0 changelog (#138)

* release(evmos): Update CHANGELOG

* Update CHANGELOG.md

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* (build): added build-reproducible to makefile

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

* docs: Add link to consensus problems if you don't upgrade your node (#146)

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* deps: bump SDK version (#147)

* deps: bump SDK version

* norace

* build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150)

Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: mergify changes (#152)

* Fix `evmosd version`  (#151)

* build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150)

Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build fix evmosd command

* Update CHANGELOG.md

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* app: fix typo in calculation of failed transactions in TPS value (#149)

Noticed while I was auditing through evmosd code that inside
the code that records TPS, that we have a typo in the calculation
of nFailed, that instead used latestNSuccessful, of which if enough
time is spent and the successful transactions have grown, while
the number of failed transactions stays still, this can cause
wrong TPS values to be reported.

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* Update .goreleaser.yml (#156)

* docs: block explorer (#158)

* docs: quick facts table (#159)

* docs: quick facts table

* Update docs/basics/chain_id.md

* changelog

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: Rohit Durvasula <88731568+rohitbison@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>
Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
fedekunze added a commit that referenced this pull request Dec 12, 2021
* release: v0.4.0 changelog (#138)

* release(evmos): Update CHANGELOG

* Update CHANGELOG.md

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* Fix `evmosd version`  (backport #151) (#154)

* Fix `evmosd version`  (#151)

* build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150)

Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build fix evmosd command

* Update CHANGELOG.md

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
(cherry picked from commit 5061449)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* app: fix typo in calculation of failed transactions in TPS value (#149) (#155)

Noticed while I was auditing through evmosd code that inside
the code that records TPS, that we have a typo in the calculation
of nFailed, that instead used latestNSuccessful, of which if enough
time is spent and the successful transactions have grown, while
the number of failed transactions stays still, this can cause
wrong TPS values to be reported.

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
(cherry picked from commit 7603acd)

Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>

* Release CHANGELOG v0.4.1 (#157)

* docs(evmos): update latest version to v0.4.0 (#139)

* docs: change `ethermintd` -> `evmosd` (#142)

* docs: migrate cosmovisor and genesis validator instructions (#141)

* docs(evmos): Add upgrade node with cosmovisor instructions

* docs(evmos): Add Incorporate changes from Cosmos Hub Vega Upgrade

* Apply suggestions from code review

* go mod tidy

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

* build: added build-reproducible to Makefile (#143)

* release: v0.4.0 changelog (#138)

* release(evmos): Update CHANGELOG

* Update CHANGELOG.md

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* (build): added build-reproducible to makefile

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

* docs: Add link to consensus problems if you don't upgrade your node (#146)

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* deps: bump SDK version (#147)

* deps: bump SDK version

* norace

* build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150)

Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: mergify changes (#152)

* Fix `evmosd version`  (#151)

* build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150)

Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build fix evmosd command

* Update CHANGELOG.md

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* app: fix typo in calculation of failed transactions in TPS value (#149)

Noticed while I was auditing through evmosd code that inside
the code that records TPS, that we have a typo in the calculation
of nFailed, that instead used latestNSuccessful, of which if enough
time is spent and the successful transactions have grown, while
the number of failed transactions stays still, this can cause
wrong TPS values to be reported.

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* Update .goreleaser.yml (#156)

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: Rohit Durvasula <88731568+rohitbison@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>
Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>

* fix: upgrade handler for v0.4.1 (#166)

* release: handler fix changelog (#167)

* docs(evmos): update latest version to v0.4.0 (#139)

* docs: change `ethermintd` -> `evmosd` (#142)

* docs: migrate cosmovisor and genesis validator instructions (#141)

* docs(evmos): Add upgrade node with cosmovisor instructions

* docs(evmos): Add Incorporate changes from Cosmos Hub Vega Upgrade

* Apply suggestions from code review

* go mod tidy

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

* build: added build-reproducible to Makefile (#143)

* release: v0.4.0 changelog (#138)

* release(evmos): Update CHANGELOG

* Update CHANGELOG.md

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* (build): added build-reproducible to makefile

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

* docs: Add link to consensus problems if you don't upgrade your node (#146)

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* deps: bump SDK version (#147)

* deps: bump SDK version

* norace

* build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150)

Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: mergify changes (#152)

* Fix `evmosd version`  (#151)

* build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150)

Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build fix evmosd command

* Update CHANGELOG.md

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* app: fix typo in calculation of failed transactions in TPS value (#149)

Noticed while I was auditing through evmosd code that inside
the code that records TPS, that we have a typo in the calculation
of nFailed, that instead used latestNSuccessful, of which if enough
time is spent and the successful transactions have grown, while
the number of failed transactions stays still, this can cause
wrong TPS values to be reported.

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* Update .goreleaser.yml (#156)

* docs: block explorer (#158)

* docs: quick facts table (#159)

* docs: quick facts table

* Update docs/basics/chain_id.md

* changelog

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: Rohit Durvasula <88731568+rohitbison@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>
Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>

* fix: intrarelayer testnet fixes

* fix tests

* lint

* comments

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com>
Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
Co-authored-by: Joe Schmoe <64335177+jolube@users.noreply.github.com>
Co-authored-by: Rohit Durvasula <88731568+rohitbison@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Giancarlos Salas <giansalex@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants