-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(imp) improve cli error messages #1371
Conversation
ENG-1470 Improve `gas=auto` error messages
There are external reports being brought to the Evmos team that the automated gas calculation is not always reliable in calculating the needed gas. ---- Example taken from external devs (provided by nic):
Problem: The error msg is actually saying that no fee is provided. However, it is not clear Solution: Refactor error messages to be more informative |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1371 +/- ##
==========================================
- Coverage 72.12% 71.59% -0.53%
==========================================
Files 256 256
Lines 17544 17549 +5
==========================================
- Hits 12653 12565 -88
- Misses 4327 4427 +100
+ Partials 564 557 -7
|
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK pending changelog entry
@Mergifyio backport release/v11.0.x |
✅ Backports have been created
|
* chore(imp) improve cli error messages * Update app/ante/evm/fee_checker.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * chore(imp) add changelog entry --------- Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 991718f) # Conflicts: # CHANGELOG.md # app/ante/cosmos/min_price.go # app/ante/cosmos/min_price_test.go # app/ante/evm/fee_checker.go
Description
Improve error messages related to gas and fees to be more informative
Closes https://linear.app/evmos/issue/ENG-1470/improve-gas=auto-error-messages