Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

[ENG-4] startport: setup #27

Merged
merged 6 commits into from
May 20, 2021
Merged

[ENG-4] startport: setup #27

merged 6 commits into from
May 20, 2021

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented May 16, 2021

Description

You can now run the network using starport:

starport serve


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze changed the title startport: setup [ENG-4] startport: setup May 18, 2021
@fedekunze fedekunze marked this pull request as ready for review May 19, 2021 13:57
@fedekunze fedekunze requested a review from khoslaventures as a code owner May 19, 2021 13:57
@fadeev
Copy link

fadeev commented May 19, 2021

Can we also perhaps merge this into cosmos/ethermint?

@fedekunze
Copy link
Contributor Author

Can we also perhaps merge this into cosmos/ethermint?

@fadeev the cosmos repo is not up to date yet with the latest stargate and geth and state changes

@khoslaventures
Copy link
Contributor

We should probably add some installation instructions for starport?

@fedekunze
Copy link
Contributor Author

We should probably add some installation instructions for starport?

yes, we need to update the documentation. Will do it on a follow up

@fedekunze fedekunze merged commit 18d1f01 into main May 20, 2021
@fedekunze fedekunze deleted the fedekunze/starport branch May 20, 2021 07:44
@fadeev
Copy link

fadeev commented May 20, 2021

fwiw we're releasing Starport v0.16 on Monday and it has protoc bundled and Go paths are automatically handled, so the only the user needs to do is:

curl https://get.starport.network/starport! | bash

(no dependencies, except Go)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants