This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Implement eth_getPendingTransactions
#259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
reviewed
Jul 12, 2021
ethereum/rpc/namespaces/eth/api.go
Outdated
Comment on lines
879
to
880
| e.logger.Debugln("invalid tx") | ||
| return nil, fmt.Errorf("invalid tx type: %T", tx) |
Codecov Report
@@ Coverage Diff @@
## main #259 +/- ##
==========================================
+ Coverage 46.04% 46.77% +0.73%
==========================================
Files 45 45
Lines 3175 3183 +8
==========================================
+ Hits 1462 1489 +27
+ Misses 1633 1613 -20
- Partials 80 81 +1
|
fedekunze
reviewed
Jul 12, 2021
fedekunze
reviewed
Jul 12, 2021
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
fedekunze
approved these changes
Jul 12, 2021
fedekunze
reviewed
Jul 12, 2021
x/evm/types/utils_test.go
Outdated
| tx = builder.GetTx().(sdk.Tx) | ||
| msg_, err := evmtypes.UnwrapEthereumMsg(&tx) | ||
| require.Nil(t, err) | ||
| require.Equal(t, *msg_, msg) |
There was a problem hiding this comment.
this seems to be failing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #244
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)