Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix: TestAppStateDeterminism could fail owing to non-determinism in cosmos-sdk simulation #1166

Merged
merged 3 commits into from
Jul 8, 2022

Conversation

adu-crypto
Copy link
Contributor

Closes: #1151

Description

update cosmos-sdk depency to latest commit in release/v0.45.x to patch the non-determinism in simulation


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze enabled auto-merge (squash) July 8, 2022 11:07
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #1166 (6acfeb8) into main (4a6f4fd) will increase coverage by 0.21%.
The diff coverage is 0.00%.

❗ Current head 6acfeb8 differs from pull request most recent head 653f960. Consider uploading reports for the commit 653f960 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
+ Coverage   61.54%   61.76%   +0.21%     
==========================================
  Files          91       90       -1     
  Lines        7281     7312      +31     
==========================================
+ Hits         4481     4516      +35     
+ Misses       2577     2573       -4     
  Partials      223      223              
Impacted Files Coverage Δ
app/utils.go 34.83% <0.00%> (ø)
rpc/types/block.go 50.46% <0.00%> (ø)
x/evm/migrations/v3/migrate.go
x/evm/keeper/grpc_query.go 69.24% <0.00%> (+0.33%) ⬆️
x/evm/module.go 52.85% <0.00%> (+0.80%) ⬆️
x/evm/types/chain_config.go 95.31% <0.00%> (+2.02%) ⬆️
x/evm/keeper/migrations.go 66.66% <0.00%> (+16.66%) ⬆️
x/evm/types/tracer.go 55.73% <0.00%> (+48.59%) ⬆️

@fedekunze fedekunze merged commit 3d2f72a into evmos:main Jul 8, 2022
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Jul 27, 2022
…osmos-sdk simulation (evmos#1166)

* update cosmos-sdk to latest commit to fix simulation failure

* fix typo: 'staking genesis' -> 'evm genesis'

Co-authored-by: Adu <foriteration@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Nov 17, 2022
…osmos-sdk simulation (evmos#1166)

* update cosmos-sdk to latest commit to fix simulation failure

* fix typo: 'staking genesis' -> 'evm genesis'

Co-authored-by: Adu <foriteration@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feemarket: non-determinism on block gas
3 participants