Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed test suite and baseapp issues from cherry-pick #4

Merged
merged 17 commits into from
Jan 11, 2023
Merged

fix: fixed test suite and baseapp issues from cherry-pick #4

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f4ef9d6
feat(app): Update post handlers
fedekunze Nov 18, 2022
572ca57
feat: refactor runTx
fedekunze Nov 18, 2022
f98a21f
Merge branch 'main' into fedekunze/update-posthandlers
fedekunze Nov 21, 2022
73a85e7
docs
fedekunze Nov 21, 2022
2c29db4
Merge branch 'fedekunze/update-posthandlers' of github.com:cosmos/cos…
fedekunze Nov 21, 2022
70e44d0
c++
fedekunze Nov 21, 2022
1276da8
Merge branch 'fedekunze/update-posthandlers' of github.com:cosmos/cos…
fedekunze Nov 21, 2022
ae489f0
tests: added unit tests to cover the 3 PostHandler cases
Vvaradinov Dec 13, 2022
60d7d81
fix: added comment on the failing case
Vvaradinov Dec 13, 2022
7e72a65
refactor: fixed case #2 events and condition
Vvaradinov Dec 14, 2022
b2c0438
Merge branch 'main' into fedekunze/runTx
Vvaradinov Jan 10, 2023
acf5f4e
fix: Updated test suite files and fixed errors in baseapp
Vvaradinov Jan 10, 2023
42248af
Apply suggestions from code review
Vvaradinov Jan 10, 2023
e183ebd
Merge branch 'main' into Vvaradinov/runTx-refactor
Vvaradinov Jan 10, 2023
4f6c1cc
fix: merged from main
Vvaradinov Jan 10, 2023
58fda49
fix: added comment for 4th case and fixed linter
Vvaradinov Jan 10, 2023
f2801e4
Update CHANGELOG.md
Vvaradinov Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
  • Loading branch information
@Vvaradinov @fedekunze
Vvaradinov and fedekunze authored Jan 10, 2023
commit 42248afca9f441e16915dabd6545449f7c915e6d
4 changes: 2 additions & 2 deletions baseapp/baseapp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ func (app *BaseApp) runTx(mode runTxMode, txBytes []byte) (gInfo sdk.GasInfo, re
return gInfo, nil, events, priority, err
}

// Case 2: Run PostHandler and only
// Case 2: tx errors and the post handler is set. Run PostHandler and revert state from runMsgs
if err != nil && app.postHandler != nil {
// Run optional postHandlers with a context branched off the ante handler ctx
postCtx, postCache := app.cacheTxContext(ctx, txBytes)
Expand Down Expand Up @@ -761,7 +761,7 @@ func (app *BaseApp) runTx(mode runTxMode, txBytes []byte) (gInfo sdk.GasInfo, re
return gInfo, result, events, priority, err
}

// Case 3: Run Post Handler with runMsgCtx so that the state from runMsgs is persisted
// Case 3: tx successful and post handler is set. Run Post Handler with runMsgCtx so that the state from runMsgs is persisted
if app.postHandler != nil {
newCtx, err := app.postHandler(runMsgCtx, tx, mode == runTxModeSimulate, err == nil)
if err != nil {
Expand Down