Skip to content

Commit

Permalink
refactor: migrate e2e/crisis away from testify suite (cosmos#14545)
Browse files Browse the repository at this point in the history
  • Loading branch information
julienrbrt authored Jan 9, 2023
1 parent 8185413 commit 64854b2
Show file tree
Hide file tree
Showing 2 changed files with 92 additions and 109 deletions.
96 changes: 92 additions & 4 deletions tests/e2e/crisis/cli_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,104 @@
package crisis

import (
"fmt"
"testing"

"github.com/stretchr/testify/suite"

"cosmossdk.io/simapp"
"github.com/cosmos/cosmos-sdk/client/flags"
clitestutil "github.com/cosmos/cosmos-sdk/testutil/cli"
"github.com/cosmos/cosmos-sdk/testutil/network"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/x/crisis/client/cli"
"github.com/cosmos/gogoproto/proto"
"gotest.tools/v3/assert"
)

func TestE2ETestSuite(t *testing.T) {
type fixture struct {
cfg network.Config
network *network.Network
}

func initFixture(t *testing.T) *fixture {
cfg := network.DefaultConfig(simapp.NewTestNetworkFixture)
cfg.NumValidators = 1
suite.Run(t, NewE2ETestSuite(cfg))

network, err := network.New(t, t.TempDir(), cfg)
assert.NilError(t, err)
assert.NilError(t, network.WaitForNextBlock())

return &fixture{
cfg: cfg,
network: network,
}
}

func TestNewMsgVerifyInvariantTxCmd(t *testing.T) {
t.Parallel()
f := initFixture(t)
defer f.network.Cleanup()

val := f.network.Validators[0]

testCases := []struct {
name string
args []string
expectErrMsg string
expectedCode uint32
respType proto.Message
}{
{
"missing module",
[]string{
"", "total-supply",
fmt.Sprintf("--%s=%s", flags.FlagFrom, val.Address.String()),
fmt.Sprintf("--%s=true", flags.FlagSkipConfirmation),
fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastSync),
fmt.Sprintf("--%s=%s", flags.FlagFees, sdk.NewCoins(sdk.NewCoin(f.cfg.BondDenom, sdk.NewInt(10))).String()),
},
"invalid module name", 0, nil,
},
{
"missing invariant route",
[]string{
"bank", "",
fmt.Sprintf("--%s=%s", flags.FlagFrom, val.Address.String()),
fmt.Sprintf("--%s=true", flags.FlagSkipConfirmation),
fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastSync),
fmt.Sprintf("--%s=%s", flags.FlagFees, sdk.NewCoins(sdk.NewCoin(f.cfg.BondDenom, sdk.NewInt(10))).String()),
},
"invalid invariant route", 0, nil,
},
{
"valid traclientCtx.Codec.UnmarshalJSON(out.Bytes(), nsaction",
[]string{
"bank", "total-supply",
fmt.Sprintf("--%s=%s", flags.FlagFrom, val.Address.String()),
fmt.Sprintf("--%s=true", flags.FlagSkipConfirmation),
fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastSync),
fmt.Sprintf("--%s=%s", flags.FlagFees, sdk.NewCoins(sdk.NewCoin(f.cfg.BondDenom, sdk.NewInt(10))).String()),
},
"", 0, &sdk.TxResponse{},
},
}

for _, tc := range testCases {
tc := tc

t.Run(tc.name, func(t *testing.T) {
cmd := cli.NewMsgVerifyInvariantTxCmd()
clientCtx := val.ClientCtx

out, err := clitestutil.ExecTestCLICmd(clientCtx, cmd, tc.args)
if tc.expectErrMsg != "" {
assert.ErrorContains(t, err, tc.expectErrMsg)
} else {
assert.NilError(t, err)
assert.NilError(t, clientCtx.Codec.UnmarshalJSON(out.Bytes(), tc.respType), out.String())

txResp := tc.respType.(*sdk.TxResponse)
assert.NilError(t, clitestutil.CheckTxCode(f.network, clientCtx, txResp.TxHash, tc.expectedCode))
}
})
}
}
105 changes: 0 additions & 105 deletions tests/e2e/crisis/suite.go

This file was deleted.

0 comments on commit 64854b2

Please sign in to comment.