add handles for events #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evmar
reviewed
Sep 14, 2024
win32/src/winapi/kernel32/init.rs
Outdated
| @@ -211,6 +211,8 @@ pub struct State { | |||
| pub resources: pe::IMAGE_DATA_DIRECTORY, | |||
| pub resource_handles: Handles<HRSRC, ResourceHandle>, | |||
|
|
|||
| pub event_handles: Handles<HEVENT, EventHandle>, | |||
There was a problem hiding this comment.
It looks like I was inconsistent about the _handles suffix between resource_handles vs files, whoops! No problem either way I guess.
There was a problem hiding this comment.
Yeah, I tried to fit in as much as possible. I believe that before I added resource_handles there was one with _handles and one without, but because resources was already taken I used the suffix. And that made it so that there was two _handles and only one without when I wrote this code 😄
LinusU
force-pushed
the
CreateEventA
branch
from
a1effb0 to
dea7e1e
Compare
|
rebased on master and adressed comments ✅ Happy to change |
|
I will revisit the names later, it's easy enough to change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which makes
CreateEventAworks when called without a name, and also implementsSetEvent