Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reset_counters implementation #5

Merged
merged 5 commits into from
Oct 6, 2022
Merged

add reset_counters implementation #5

merged 5 commits into from
Oct 6, 2022

Conversation

egor-lukin
Copy link
Contributor

@egor-lukin egor-lukin commented Sep 30, 2022 •
edited
Loading

Added 'reset_counters' implementation. It resets one counter per transaction.

@egor-lukin egor-lukin marked this pull request as ready for review October 3, 2022 16:13
@egor-lukin egor-lukin requested a review from palkan October 3, 2022 16:13
palkan
palkan approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@palkan palkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Left one minor comment

lib/activerecord_slotted_counters/has_slotted_counter.rb Outdated Show resolved Hide resolved
@egor-lukin egor-lukin merged commit fa5b8cb into evilmartians:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palkan palkan palkan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egor-lukin @palkan