Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table row link preloading and accessibility #2596

Conversation

zachstence
Copy link
Member

Description

hovering on the first row
image

test-env orders demo

2024-10-01.15-52-36.mov

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
    - I have added to the docs where applicable
    - I have added to the VS Code extension where applicable

@zachstence zachstence self-assigned this Oct 1, 2024
@zachstence zachstence linked an issue Oct 1, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: a868bef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@evidence-dev/core-components Patch
my-evidence-project Patch
e2e-spa Patch
e2e-themes Patch
@evidence-dev/components Patch
evidence-test-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 3:00pm
next-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 3:00pm

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for next-docs-evidence ready!

Name Link
🔨 Latest commit a868bef
🔍 Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/66fd5e3870b51b00086c948d
😎 Deploy Preview https://deploy-preview-2596--next-docs-evidence.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for evidence-test-env ready!

Name Link
🔨 Latest commit a868bef
🔍 Latest deploy log https://app.netlify.com/sites/evidence-test-env/deploys/66fd5e38bf5d300009b4b572
😎 Deploy Preview https://deploy-preview-2596--evidence-test-env.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit a868bef
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/66fd5e3848ddc400087754cf
😎 Deploy Preview https://deploy-preview-2596--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zachstence zachstence changed the title Feat/2565 ensure client side navigation when following a rowlink in a table Table row link preloading and accessibility Oct 1, 2024
@mcrascal
Copy link
Member

mcrascal commented Oct 2, 2024

Chevron column is a little shaky on mobile in the docs -- the header row isn't underlined for that column.

It'd be fine to ship this w/out the chevron if that'd get it in this release.

image

@zachstence
Copy link
Member Author

Chevron column is a little shaky on mobile in the docs -- the header row isn't underlined for that column.

It'd be fine to ship this w/out the chevron if that'd get it in this release.

@mcrascal
Good catch, I didn't see that in Chrome. I just added another <th /> for that column so it should look good in all browsers now

@zachstence
Copy link
Member Author

I also noticed that the showLinkCol prop has been broken. I fixed it:

Without showLinkCol:
image

With showLinkCol:
image

Copy link
Member

@mcrascal mcrascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachstence zachstence merged commit 4347a47 into next Oct 2, 2024
18 checks passed
@zachstence zachstence deleted the feat/2565-ensure-client-side-navigation-when-following-a-rowlink-in-a-table branch October 2, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure client side navigation when following a rowlink in a table
3 participants